fix: location deletion not showing up in activity log #1309

[squigglybob]

resolves #1309

[squigglybob]

@corsacca I think that fixes it

[corsacca]

In testing i see this fixes the issue for all locations added from now on.
In deleting the a location created before this PR, the delete message will look something like:

[squigglybob]

is that ok? or how would you like that to change?

[corsacca]

I don't know if there is anything we can do since the data was not there originally

[corsacca]

Unless we write a special check that tells if it is the old format and just displays "location removed"

[squigglybob]

that would be possible I'm sure

[squigglybob]

@corsacca something like this? although it adds two new translation strings.

The 'location removed' string shouldn't be hit by anybody though, as prior to this PR there hasn't been an activity log for removal of location_meta

[corsacca]

@squigglybob Thanks coding a solution.
If the new way adds extra translations and will rarely be hit, then lets just for for the solution you had initially
Thanks for your patience with the back and forth.

[squigglybob]

@corsacca only one extra translation string "location added" will still be needed for any activity logs for the addition of a location where that location was subsequently removed.

Previously in that case it just showed the truncated string " added to locations" (from '%1$s added to locations" translation but the new translation string would change that to "location added".

We could just leave the older logs as they are as "added to locations" still says the same thing as "location added".

Let me know what you think.