Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 708 #1266

Merged
merged 12 commits into from
Apr 9, 2021
Merged

Issue 708 #1266

merged 12 commits into from
Apr 9, 2021

Conversation

cwuensche
Copy link
Contributor

No description provided.

@corsacca
Copy link
Member

@cwuensche
The cookie didn't save for me when i had more than 30 records.
We can put the code in the details.js instead of the contacts.js and the groups.js, this way it will work for any post type.

@corsacca
Copy link
Member

If we just save an array of the ids, we can generated the links to the prev and next by looking at the position in the array.

@cwuensche
Copy link
Contributor Author

I have almost finished this. I changed the code so IDs are saved instead of entire posts. I'm working on implementing code that will fetch posts based on the ID so I can populate the next/prev links.

- Fixed the issue causing problems saving a cookie when more than 30 results are filtered.
@corsacca
Copy link
Member

corsacca commented Apr 6, 2021

@cwuensche awesome. This seems to work well.
Would you be able to but the prev and next links as buttons in the top right?
Something like:
image

@corsacca corsacca linked an issue Apr 6, 2021 that may be closed by this pull request
@cwuensche
Copy link
Contributor Author

@corsacca I added a navigation arrow on the left and right side of the bar. Let me know what you think about the way I did it. I used the original image as an example, but we could change it to display like how you have it here, except on the right side of the navigation bar.

@corsacca
Copy link
Member

corsacca commented Apr 7, 2021

This is looking great @cwuensche!
We are liking the icon placement.
A couple changes:

  • set the height to 20px
  • have a hover text with "previous record" and "next record"
  • have the icons show up on mobile view too on each side on the other icons:
    image

@cwuensche
Copy link
Contributor Author

@corsacca I haven't pushed the changes yet, but it seems like it would respond better if I had the arrows on both mobile and desktop view right next to each other like you have in the image on this page. While I was resizing the browser on desktop, the arrows started going to the next line. It would probably work better having the arrows side by side like you have on both desktop and mobile.

@corsacca
Copy link
Member

corsacca commented Apr 7, 2021

Hey @cwuensche ,
I'm still seeing the large icons:
image
Is that the same for you?

@corsacca
Copy link
Member

corsacca commented Apr 9, 2021

Thanks @cwuensche !

@corsacca corsacca merged commit 3884f3d into DiscipleTools:master Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

next record button for list of records
2 participants