New notification drop down #300 #1244
Conversation
|
Thanks for the PR! |
|
It looks like you've got all the pieces and followed the mock-up. We'd like the [All] [Unread] buttons to stay side by side and think it would be better to swap the "Mark All Read / Settings" in the upper right with the "See All" link that takes you to the notifications page so that there is more room for the side by side buttons on smaller screens. See attached image. |
|
Ok, those things are ready to go, but one last question regarding the notification count: do you want it to stay off and up to the right as in... or more inline and less into the margin as in the figma mockup... |
|
@squigglybob that looks a lot better! I think it got messed up at some point. |
|
sorry @corsacca only just saw your message, so shall i make it more like the second picture? |
That would be amazing! |
…ation page and dropdown box
|
ok @corsacca , that should hopefully be it 🙂 I've also changed the styling of the notification count on the notification page to match that in the dropdown box (it had the same not quite floating badge number style) |
|
@squigglybob we still want the "settings" and the "mark all as read". They can show up at the bottom instead of the top. |
|
Ah, sorry, missed the word swap :0/ I'll fix it up tomorrow
…On Wed, 24 Mar 2021, 4:51 pm corsacca, ***@***.***> wrote:
@squigglybob <https://github.com/squigglybob> we still want the
"settings" and the "mark all as read". They can show up at the bottom
instead of the top.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1244 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACK4RFSZWQDUAYHLLNNVRW3TFIKAXANCNFSM4ZW6SK6A>
.
|
…ropdown changes and v.v
|
Hopefully this should be good to go @corsacca |
|
:) thanks @squigglybob |
resolves #300
I've mostly left the styling of the notifications header part the same as on the notification page, with the result that the All/Unread buttons stack on top of each other the same as the page one's do at certain screen widths. Let me know if you want that changed.