Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deleting a location is not getting logged #1309

Closed
mikeallbutt opened this issue Apr 23, 2021 · 6 comments · Fixed by #1340
Closed

Deleting a location is not getting logged #1309

mikeallbutt opened this issue Apr 23, 2021 · 6 comments · Fixed by #1340
Assignees
@squigglybob
Labels
bug help wanted

Comments

@mikeallbutt
Copy link
Contributor

If a location is set in the Location or Address field in the Details tile and the location is removed (by clicking on the red X on the right side of the field),
Screen Shot 2021-04-22 at 22 34 11
then the information is correctly removed and the field becomes empty. When this type of thing is done with other fields (ie. data being removed or updated - like a phone number) then that activity is logged and appears on the right site in the Comments and Activity tile.

When a location is set, then it does get logged and appears in the Comments and Activity tile. The same should happen when a location is removed.
@squigglybob
Copy link
Collaborator

Hi @corsacca , i'm happy to take this one...

@corsacca
Copy link
Member

corsacca commented May 3, 2021

Thanks @NathTech

@squigglybob
Copy link
Collaborator

Hi @corsacca or @mikeallbutt I have had a look under Contacts and Groups, and can't find anything matching the above screenshot...

The location or address inputs work as expected for those two pages.

Could you give some more information please as to where this issue is being found?

Thanks

@corsacca
Copy link
Member

corsacca commented May 3, 2021

@squigglybob For this one you'll need to add a mapbox key from WP Admin > Mapping > geolocation

@squigglybob
Copy link
Collaborator

i'll get one now. I've also noticed that this field is hidden now from the code side,
image

@squigglybob
Copy link
Collaborator

No problem, I've managed to get it showing, and can see the problem :) i'm on it

@squigglybob squigglybob mentioned this issue May 5, 2021
Merged
corsacca pushed a commit that referenced this issue May 10, 2021
@squigglybob
fix: location deletion not showing up in activity log #1309 (#1340)
f9cc4c7 
* fix: store address label in activity log note, and use it if the location_grid_meta has been deleted

* fix: trigger deletion of post location_meta to correctly log the deletion activity

* fix: don't try and display address if we really can't find it

* fix: remove unused 'location removed' translation string

* Just fix for messages going forward.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@squigglybob squigglybob

Labels
bug help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: location deletion not showing up in activity log #1309 squigglybob/disciple-tools-theme
3 participants
@squigglybob @corsacca @mikeallbutt