Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deserialized layout document close. #404

Merged
merged 1 commit into from
Dec 25, 2022

Conversation

pkindruk
Copy link
Contributor

@pkindruk pkindruk commented Dec 2, 2022

Recently I mentioned that LayoutElement._root doesn't have correct value after deserialization. When we deserialize layout from xml enclosing element is not finished with yet and therefore doesn't have correct parent yet.
This state prevents LayoutRoot.ElementRemoved from being called on close, which leads to skipped call to DockingManager.CollectLayoutItemsDeleted.

Also I mentioned that documents closed via deletion from DockingManager.DocumentsSource did not have their Content property set to null. Though we do it for AnchorablesSource and in ExecuteCloseCommand, so I added it.

@Dirkster99 Dirkster99 merged commit 4f47fe4 into Dirkster99:master Dec 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants