Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: test bundler module resolution #442

Merged
merged 1 commit into from
Jan 11, 2024
Merged

chore: test bundler module resolution #442

merged 1 commit into from
Jan 11, 2024

Conversation

danielroe
Copy link
Collaborator

This is a 'canary' pull request. It aims to ensure that the ecosystem is ready for a shift in the default Nuxt TypeScript module resolution from 'Legacy' to 'Bundler': nuxt/nuxt#24837. You'll need to run your build + type checking tests to verify that things still work; I'm hoping that CI will do that for us so we get an immediate indication of whether there's anything to investigate further here.

'Bundler' module resolution is recommended by Vue and by Vite, but unfortunately there are still many packages that do not have the correct entries in their package.json.

This might include this module or packages that are used by this module. You can see, for example: https://arethetypeswrong.github.io/?p=nuxt-graphql-client. The initial red X for node10 needs to be fixed in https://github.com/nuxt/module-builder; you can ignore that for now.

If there are any errors reported in CI for this PR, it would be good to fix them for the sake of any users of this module who enable the Bundler module resolution. Feel free to ping me or others on the Nuxt Discord if you need any help resolving any issues discovered by this PR - and feel free to check out nuxt/nuxt#24837 for any feedback or comments from others affected.

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7b40c14) 93.34% compared to head (8a855f4) 93.34%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #442   +/-   ##
=======================================
  Coverage   93.34%   93.34%           
=======================================
  Files           6        6           
  Lines         631      631           
  Branches      120      119    -1     
=======================================
  Hits          589      589           
+ Misses         42       41    -1     
- Partials        0        1    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Diizzayy Diizzayy merged commit b7a1cb2 into main Jan 11, 2024
6 checks passed
@danielroe danielroe deleted the bundler-resolution branch January 11, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants