Handle incorrect bulk string size in RESP by returning adequate error message instead of panicking #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… message instead of panicking
|
amazing PR! LGTM. Thank you so much for the contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed that wrong bulk string size in RESP results in panic. I've added some checks to prevent this behavior and return user friendly message.
It can be tested either by running
parser_test.gotests that I've added or by sending malformed packet:e.g.
echo -e -n "*3\r\n\$4\r\nSET\r\n\$1\r\nA\r\n\$1\r\nB\r\n" | nc 127.0.0.1 6379This is my first time contributing, let me know if I am doing something incorrectly.