fix: Update streaming connection URL when config received #891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
38a65ae
to
745cb0c
Compare
745cb0c
to
399eb12
Compare
399eb12
to
ac18b31
Compare
suthar26
approved these changes
Jul 5, 2024
ajwootto
reviewed
Jul 5, 2024
sdk/js/src/Client.ts
Outdated
| ) | ||
| } | ||
| } | ||
| if ( |
There was a problem hiding this comment.
should this be an else if? otherwise it might open a new streaming connection and then immediately reconnect it
There was a problem hiding this comment.
true good point, fixed
ajwootto
reviewed
Jul 5, 2024
sdk/js/src/StreamingConnection.ts
Outdated
| @@ -11,6 +11,12 @@ export class StreamingConnection { | |||
| this.openConnection() | |||
| } | |||
|
|
|||
| public updateURL(url: string): void { | |||
| this.url = url | |||
There was a problem hiding this comment.
might be better to change this property after you call close()
ac18b31
to
04d372d
Compare
ajwootto
approved these changes
Jul 8, 2024
04d372d
to
7519c00
Compare
7519c00
to
be7cfaf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.