Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(menu): width过小时生成省略号并支持悬浮 #614

Merged
merged 4 commits into from
May 11, 2022
Merged

feat(menu): width过小时生成省略号并支持悬浮 #614

merged 4 commits into from
May 11, 2022

Conversation

GaoNeng-wWw
Copy link
Collaborator

feat:

  • 如果menu为横向排列,当宽度过小时会出现省略号

fix

  • 优化了横向菜单中如果存在submenu,鼠标悬浮上去后将会出现次级悬浮菜单
  • 优化了横向菜单中如果存在submenu,鼠标悬浮上去后将会出现次级悬浮菜单的动画问题

@kagol
Copy link
Member

kagol commented May 6, 2022

@GaoNeng-wWw composableshooks我理解是同一个东西,在vue里面应该统一叫composables,里面的文件名使用use-前缀。

@GaoNeng-wWw
Copy link
Collaborator Author

@GaoNeng-wWw composableshooks我理解是同一个东西,在vue里面应该统一叫composables,里面的文件名使用use-前缀。

我把composables改为了helper,但是hook保留下来了,这样就不存在文件夹名称重复问题了

@kagol
Copy link
Member

kagol commented May 10, 2022

@GaoNeng-wWw composableshooks我理解是同一个东西,在vue里面应该统一叫composables,里面的文件名使用use-前缀。

我把composables改为了helper,但是hook保留下来了,这样就不存在文件夹名称重复问题了

如果helper不是composable只是工具函数,是不是就不应该以use开头呢?以use开头会误以为是vue里面的composable

@kagol kagol added the feature New feature label May 11, 2022
@kagol kagol merged commit ba04ce2 into DevCloudFE:dev May 11, 2022
@GaoNeng-wWw GaoNeng-wWw deleted the gaoneng/menu branch May 22, 2022 02:45
@kagol kagol changed the title feat: width过小时生成省略号并支持悬浮 feat(menu): width过小时生成省略号并支持悬浮 Jun 18, 2022
kagol pushed a commit that referenced this pull request Aug 1, 2022
* feat: 当宽度过小时的新功能

* fix: 移除了debug时的console

* refactor: 重构文件名
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants