Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: fix some deprecation warnings #1869

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

fu050409
Copy link
Collaborator

处理弃用警告

What's Changed

  1. 修复了以下警告:

    [vite] warning:
    C:/Users/nocti/Desktop/Workspace/vue-devui/packages/devui-vue/docs/.vitepress/demo/Demo.vue
    28 |      const DemoComponent =
    29 |        props.demoList?.[props.targetFilePath]?.default ?? defineAsyncComponent(() => import(/* vite-ignore */ props.targetFilePath));
    30 |      watch(
       |      ^
    31 |        () => route.path,
    32 |        (path) => {
    The above dynamic import cannot be analyzed by vite.
    See https://github.com/rollup/plugins/tree/master/packages/dynamic-import-vars#limitations for supported dynamic import formats. If this is intended to be left as-is, you can use the /* @vite-ignore */ comment inside the import() call to suppress this warning.

    已知这是一个拼写错误,vite要求使用/* @vite-ignore */而不是/* vite-ignore */

  2. 修复了 [@vue/compiler-sfc] ::v-deep usage as a combinator has been deprecated. Use :deep(<inner-selector>) instead of ::v-deep <inner-selector>.,这是由于新版的Vue使用:deep(<inner-selector>)而不是::v-deep <inner-selector>

  3. 更新了CONTRIBUTING.md,之前的PR已经被Merge,我们无需要求开发者使用旧版pnpm

@fu050409 fu050409 requested a review from GreatZPP May 31, 2024 03:44
Copy link

PR preview has been successfully built and deployed to https://vue-devui-pr-1869.surge.sh.

Copy link

Deploy PR preview failed.

3 similar comments
Copy link

Deploy PR preview failed.

Copy link

github-actions bot commented Jun 3, 2024

Deploy PR preview failed.

Copy link

github-actions bot commented Jun 3, 2024

Deploy PR preview failed.

@fu050409
Copy link
Collaborator Author

fu050409 commented Jun 3, 2024

Deploy PR preview failed.

这个机器人怎么回事

Copy link

github-actions bot commented Jun 7, 2024

Deploy PR preview failed.

16 similar comments
Copy link

github-actions bot commented Jun 8, 2024

Deploy PR preview failed.

Copy link

github-actions bot commented Jun 8, 2024

Deploy PR preview failed.

Copy link

Deploy PR preview failed.

Copy link

Deploy PR preview failed.

Copy link

Deploy PR preview failed.

Copy link

Deploy PR preview failed.

Copy link

Deploy PR preview failed.

Copy link

Deploy PR preview failed.

Copy link

Deploy PR preview failed.

Copy link

Deploy PR preview failed.

Copy link

Deploy PR preview failed.

Copy link

Deploy PR preview failed.

Copy link

Deploy PR preview failed.

Copy link

Deploy PR preview failed.

Copy link

Deploy PR preview failed.

Copy link

Deploy PR preview failed.

@BigFrontEnd-China
Copy link

image

image

这个代码还没merge到dev分支吗?目前还是有这个错误

@BigFrontEnd-China
Copy link

BigFrontEnd-China commented Jul 1, 2024

image
按@vite-ignore修复后OK了

@fu050409
Copy link
Collaborator Author

fu050409 commented Jul 1, 2024

image 按@vite-ignore修复后OK了

目前还是在等 @GreatZPP 的 review,社区这边应该是有统一时间对 PR 进行审查合并

Copy link

github-actions bot commented Jul 1, 2024

Deploy PR preview failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants