Input: appletouch - initialize work before device registration

commit 9f3ccdc3f6ef10084ceb3a47df0961bec6196fd0 upstream. Syzbot has reported warning in __flush_work(). This warning is caused by work->func == NULL, which means missing work initialization. This may happen, since input_dev->close() calls cancel_work_sync(&dev->work), but dev->work initalization happens _after_ input_register_device() call. So this patch moves dev->work initialization before registering input device Fixes: 5a6eb67 ("Input: appletouch - improve powersaving for Geyser3 devices") Reported-and-tested-by: [email protected] Signed-off-by: Pavel Skripkin <[email protected]> Link: https://lore.kernel.org/r/[email protected] Cc: [email protected] Signed-off-by: Dmitry Torokhov <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
DespairFactor · Jan 5, 2022 · 9f329d0 · 9f329d0
1 parent 2a4f551
commit 9f329d0
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/drivers/input/mouse/appletouch.c b/drivers/input/mouse/appletouch.c
@@ -916,15 +916,15 @@ static int atp_probe(struct usb_interface *iface,
  set_bit(BTN_TOOL_TRIPLETAP, input_dev->keybit);
  set_bit(BTN_LEFT, input_dev->keybit);
 
+ INIT_WORK(&dev->work, atp_reinit);
+
  error = input_register_device(dev->input);
  if (error)
  goto err_free_buffer;
 
  /* save our data pointer in this interface device */
  usb_set_intfdata(iface, dev);
 
- INIT_WORK(&dev->work, atp_reinit);
-
  return 0;
 
  err_free_buffer: