libmedia: Add MediaPlayer() function for backward compatibility

* package name argument got added to MediaPlayer in fd90fdf, which broke most prebuilt libcameraservice as they were built before this commit was merged * although a shim for this exists, it doesn't work well and crashes cameraservice whenever MediaPlayer() is called, seemingly due to a stack corruption Change-Id: I1f8e112b1ab9cc96cb877dbee14767c28a377ab1
DerpFest-Realme7Pro · Apr 17, 2021 · fc9862b · fc9862b
1 parent b5b146d
commit fc9862b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/media/libmedia/include/media/mediaplayer.h b/media/libmedia/include/media/mediaplayer.h
@@ -207,7 +207,8 @@ class MediaPlayer : public BnMediaPlayerClient,
                     public virtual IMediaDeathNotifier
 {
 public:
-    MediaPlayer(const std::string opPackageName = "");
+    MediaPlayer();
+    MediaPlayer(const std::string opPackageName);
     ~MediaPlayer();
             void            died();
             void            disconnect();

diff --git a/media/libmedia/mediaplayer.cpp b/media/libmedia/mediaplayer.cpp
@@ -41,6 +41,10 @@ namespace android {
 
 using media::VolumeShaper;
 
+MediaPlayer::MediaPlayer() : MediaPlayer("" /*opPackageName*/)
+{
+}
+
 MediaPlayer::MediaPlayer(const std::string opPackageName) : mOpPackageName(opPackageName)
 {
     ALOGV("constructor");