Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BasePlayer modification #216

Merged
merged 2 commits into from
Feb 8, 2023
Merged

BasePlayer modification #216

merged 2 commits into from
Feb 8, 2023

Conversation

romaf5
Copy link
Collaborator

@romaf5 romaf5 commented Feb 3, 2023

  • Player configuration override

Example:

config:
  env_config:
     ... train parameters ... 
  player:
      env_config:
         ... play parameters ...

Test plan:

  1. Train models for two different scenarios
    python runner.py --train --file rl_games/configs/brax/ppo_ant.yaml
    python runner.py --train --file rl_games/configs/ppo_cartpole.yaml

  2. Run model with & without proposed change. (No crash, similar results)

  3. Benchmark change (brax/ant)

Time Before After
real 1m32.151s 0m42.622s
user 1m21.269s 0m49.443s
sys 0m31.144s 0m17.270s

@romaf5 romaf5 requested a review from Denys88 February 3, 2023 22:51
@romaf5 romaf5 changed the title [WIP] BasePlayer modification BasePlayer modification Feb 4, 2023
@ViktorM ViktorM merged commit fff05b7 into master Feb 8, 2023
@ViktorM ViktorM deleted the roman/player_conf_vec branch February 8, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Denys88 Denys88 Denys88 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@romaf5 @Denys88 @ViktorM