Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DIPU build 改进 #346

Open
lljbash opened this issue Oct 18, 2023 · 0 comments
Open

DIPU build 改进 #346

lljbash opened this issue Oct 18, 2023 · 0 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@lljbash
Copy link
Collaborator

lljbash commented Oct 18, 2023

Read

PRs

  • (lljbash) CMake 优化 #301

    • 将编译好的 DIOPI 以 imported 形式引入,可以以 WITH_DIOPI 的 CMake 参数设置位置
    • 删除所有 LIBRARY_PATH 的需求(会影响 rpath),并正确设置 DIOPI 和 DIPU 的 rpath
      • 删除对 DIOPI LD_LIBRARY_PATH 的需求(由 rpath 寻找),因此总是可以正确找到编译 DIPU 时用的版本
    • 修复并优化 cpp test 的 CMake
    • 格式化所有受影响的 CMake
    • 将一些非 DIPU 的 include dir 设置为 isystem
  • Make all in CMake #351

    • dipu autogen 转移到 CMake 中,添加适当的依赖,移除显式生成的相关 script
    • dipu python C_ext 转移到 CMake 中编译,暂时移除 setup.py
    • 设置 lib 输出目录,代替 mv
  • One step install #358

    • 支持 WITH_DIOPI=internal 来就地编译 DIOPI
    • 把 DIOPI 的 build.sh 里面那些配置组干掉,相应地把配置组功能在 CMake 里面加上支持
    • Caikun/enhance profiler #355 中 thirdparty build 的重构
    • pip install
  • add Interface in CMake for diopi_impl #398

    • WITH_DIOPI 拆解为 WITH_DIOPI_LIBRARYWITH_DIOPI_INCLUDE,允许提供自定义的 lib 及 *.hpp 文件
  • Pass CMAKE_EXPORT_COMPILE_COMMANDS from DIPU to DIOPI #425

    • 向下传递 CMAKE_EXPORT_COMPILE_COMMANDS
  • feat: pass CMAKE_BUILD_TYPE into DIOPI #428

TODO list

(move the item into PRs when you start working on one)

CMake

Python one-step setup

DIOPI

  • DIOPI 模块化、现代化
@lljbash lljbash added bug Something isn't working enhancement New feature or request labels Oct 18, 2023
@lljbash lljbash self-assigned this Oct 18, 2023
@lljbash lljbash mentioned this issue Oct 18, 2023
@lljbash lljbash changed the title DIPU build 优化 DIPU build 改进 Oct 19, 2023
This was referenced Oct 26, 2023
LeungChiNan pushed a commit to DeepLink-org/deeplink.framework.dev that referenced this issue Dec 8, 2023
* support generator

* random 、normal、dropout operators support generator parameter

* support generator in cuda and camb

* diopirt support generator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants