Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MMCV分支删减 #330

Open
Bonbon-Tang opened this issue Oct 10, 2023 · 2 comments
Open

MMCV分支删减 #330

Bonbon-Tang opened this issue Oct 10, 2023 · 2 comments

Comments

@Bonbon-Tang
Copy link
Collaborator

  1. dipu的one iter测试时，使用了两个版本的mmcv， 跑基准测试时（cpu）使用了一版mmcv，跑对比测试时（diopi）又使用了另一版mmcv，之前说是mmcv适配好diopi后，cpu代码不好用了。此信息需要确认，并修复为适配好dipu的mmcv cpu和diopi都能使用。且one iter测试时仅使用一个mmcv。
  2. diopi中mmcv的测试，使用的mmcv分支为diopi的submodule。需要删除此submodule。后续测试基于一个固定的mmcv commit id(目前是最新的main分支)。
  3. 目前的mmcv测试中没有测试寒武纪的mmcv实现。需要把寒武纪的mmcv实现加入ci测试。（可类比目前代码中cuda上的测试方法）（P3）
@Bonbon-Tang
Copy link
Collaborator Author

Bonbon-Tang commented Oct 10, 2023 •
edited
Loading

针对问题1： #325 已经完成

@Bonbon-Tang
Copy link
Collaborator Author

针对问题2 定位到最新MMCV库依赖MMEngine

LeungChiNan pushed a commit to DeepLink-org/deeplink.framework.dev that referenced this issue Dec 8, 2023
@yewentao256
ywt/fix: index-put-support-multi-dtype-indices (DeepLink-org#330)
5b2a457 
* fix: index-put-support-multi-dtype-indices

* fix: index put cast byte/bool to int32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Bonbon-Tang