Bastion is slacking off???

[Capt-Blitz]

Hey...I don't know exectly what is happening but on the GoldenNovaYugioh discord server we have noticed a trend of Bastion just refusing to acknowledge serch queries.
We don't know whats happening, can one of you look at it?

[kevinlul]

Do you have a server ID?

[kevinlul]

Observed similar behaviour in a different server on April 23 and April 25. However, as far as I can tell, in those cases, the earlier attempts are not being sent from Discord to Bastion. I don't have evidence to rule out some bug in Discord.js event processing or the initial Bastion preprocessing.

bastion-bot/src/events/message-search.ts

Lines 245 to 269 in 3169c02

	async run(message: Message): Promise<void> {
	if (shouldIgnore(message)) {
	return;
	}
	// Deactivate new functionality in select servers
	// Always active in direct messages, threads, voice chats
	if (
	message.guildId &&
	this.abdeploy.has(message.guildId) &&
	!message.channel.isThread() &&
	!message.channel.isVoiceBased()
	) {
	return;
	}
	if (!message.guildId && process.env.BOT_NO_DIRECT_MESSAGE_SEARCH) {
	return;
	}
	if (!this.eventLocks.has(message.id, this.type)) {
	return;
	}
	const delimiter = getDelimiter(message);
	let inputs = preprocess(message.content, delimiter);
	if (inputs.length === 0) {
	return;
	}

https://discord.com/developers/docs/reference#consistency

[Capt-Blitz]

I don't see a server ID option, but here is the invite link
https://discord.gg/UPD9dcxu

[kevinlul]

Per https://discord.com/api/v8/invites/UPD9dcxu?with_counts=true, the server ID is 745060455327858819. Checking recent logs.

[kevinlul]

From the past week, the only thing I've spotted is two searches within a second for "share the pain" today by different users.

[kevinlul]

Approved to log channel 751160897032028361 in the same way as below

bastion-bot/src/events/message-search.ts

Lines 246 to 253 in 1024cbb

	if (message.channelId === process.env.LOG_ALL_MESSAGE_CHANNEL) {
	this.#logger.verbose(
	JSON.stringify({
	...(message.toJSON() as object),
	channel: message.channel.toJSON()
	})
	);
	}

[kevinlul]

Logging is active now. Please let us know if you spot any misses effective from May 10 at 3:47 am ET.

[kevinlul]

Four months ago in #434, a change was introduced that synchronized the ignore condition between the message ping and message search listeners. This added a new condition to ignore replies for message search. This behaviour is incorrect, unintuitive, and undocumented as all replies are ignored, not just direct replies to Bastion, and there are no merits of ignoring even those for message search. This should account for the majority of cases of this "heisenbug", though there still remain uncommon cases of Discord not sending the message to Bastion.

[kevinlul]

@Capt-Blitz A fix was deployed. Please let me know if this restores your search experience or if you have any other feedback.

[kevinlul]

The team reached out on Discord to the opener and confirmed the fix. There is still a follow-up idea to add a context menu command to resend to Bastion, but the reply fix covers most situations.