Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARIA components & refactoring #40

Merged
merged 57 commits into from
Nov 26, 2023
Merged

Conversation

DavidVollmers
Copy link
Owner

  • Removed redundant interfaces of all Headless UI components
  • Introduced ARIA-based interfaces for Headless UI components
  • Removed IgnisRigidComponentBase
  • Introduced DynamicComponentBase

Copy link

codecov bot commented Nov 26, 2023

Codecov Report

Attention: 426 lines in your changes are missing coverage. Please review.

Comparison is base (66a6104) 43.90% compared to head (12b3339) 42.73%.

Files Patch % Lines
...nd/Ignis.Components.HeadlessUI/RadioGroupOption.cs 0.00% 38 Missing ⚠️
...kages/Tailwind/Ignis.Components.HeadlessUI/Menu.cs 35.29% 29 Missing and 4 partials ⚠️
...Tailwind/Ignis.Components.HeadlessUI/RadioGroup.cs 0.00% 33 Missing ⚠️
...s/Tailwind/Ignis.Components.HeadlessUI/TabGroup.cs 0.00% 31 Missing ⚠️
....Components.HeadlessUI/Aria/AriaPopupExtensions.cs 0.00% 28 Missing ⚠️
...es/Tailwind/Ignis.Components.HeadlessUI/Listbox.cs 56.14% 18 Missing and 7 partials ⚠️
...ailwind/Ignis.Components.HeadlessUI/SwitchGroup.cs 0.00% 25 Missing ⚠️
...Tailwind/Ignis.Components.HeadlessUI/Disclosure.cs 0.00% 20 Missing ⚠️
...ckages/Tailwind/Ignis.Components.HeadlessUI/Tab.cs 0.00% 18 Missing ⚠️
packages/Ignis.Components/DynamicComponentBase.cs 53.57% 7 Missing and 6 partials ⚠️
... and 28 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #40      +/-   ##
==========================================
- Coverage   43.90%   42.73%   -1.18%     
==========================================
  Files          81       82       +1     
  Lines        2619     2286     -333     
  Branches        0      439     +439     
==========================================
- Hits         1150      977     -173     
+ Misses       1469     1170     -299     
- Partials        0      139     +139     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DavidVollmers DavidVollmers merged commit f99ac90 into master Nov 26, 2023
7 of 9 checks passed
@DavidVollmers DavidVollmers deleted the features/aria-attributes branch November 26, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant