Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework reactivity system & Introduce event system #30

Merged
merged 16 commits into from
Oct 6, 2023

Conversation

DavidVollmers
Copy link
Owner

  • Rework and improve the reactivity system
    • Renamed the Value parameter of the ReactiveSection component to For
    • Introduced a base class ReactiveExpression for reactivity and a new class ReactiveReference to be used with reference types
    • Limited the ReactiveValue class to be only used with value types
  • Introduce an event system which will be extended and used for later features

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (e58ace9) 43.44% compared to head (d5bdff7) 43.90%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
+ Coverage   43.44%   43.90%   +0.46%     
==========================================
  Files          77       81       +4     
  Lines        2594     2619      +25     
==========================================
+ Hits         1127     1150      +23     
- Misses       1467     1469       +2     
Files Coverage Δ
.../Ignis.Components.Reactivity/ReactiveExpression.cs 100.00% <100.00%> (ø)
...s/Ignis.Components.Reactivity/ReactiveReference.cs 100.00% <100.00%> (ø)
...ges/Ignis.Components.Reactivity/ReactiveSection.cs 92.59% <100.00%> (ø)
...kages/Ignis.Components.Reactivity/ReactiveValue.cs 100.00% <100.00%> (ø)
packages/Ignis.Components/HostContextBase.cs 100.00% <100.00%> (ø)
packages/Ignis.Components/IgnisComponentBase.cs 88.63% <100.00%> (+0.26%) ⬆️
...kages/Ignis.Components/IgnisComponentExtensions.cs 56.60% <ø> (ø)
....Components/Extensions/IgnisComponentExtensions.cs 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DavidVollmers DavidVollmers merged commit 633df39 into master Oct 6, 2023
6 of 7 checks passed
@DavidVollmers DavidVollmers deleted the features/complex-reactivity branch October 6, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant