Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix transition/dialog/outlet bug & e2e tests #27

Merged
merged 13 commits into from
Sep 22, 2023

Conversation

DavidVollmers
Copy link
Owner

This PR introduces e2e tests running against https://e2e.ignis.dvolper.dev to test full functionality of opening/closing a Dialog within a Transition rendered from a DialogOutlet.

This PR also fixes a bug with the above described issue.

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.14% 🎉

Comparison is base (28eb66d) 38.21% compared to head (40e0d95) 38.35%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #27      +/-   ##
==========================================
+ Coverage   38.21%   38.35%   +0.14%     
==========================================
  Files          75       75              
  Lines        2570     2576       +6     
==========================================
+ Hits          982      988       +6     
  Misses       1588     1588              
Files Changed Coverage Δ
packages/Ignis.Components/ContentRegistry.cs 100.00% <100.00%> (ø)
packages/Ignis.Components/IgnisComponentBase.cs 88.37% <100.00%> (+0.27%) ⬆️
...is.Components/IgnisContentProviderComponentBase.cs 93.10% <100.00%> (ø)
...Tailwind/Ignis.Components.HeadlessUI/Transition.cs 91.12% <100.00%> (+0.21%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DavidVollmers DavidVollmers merged commit 45e3b32 into master Sep 22, 2023
9 checks passed
@DavidVollmers DavidVollmers deleted the features/e2e-tests branch September 22, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant