Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Dialog/DialogOutlet/Transition behavior #12

Merged
merged 14 commits into from
Sep 5, 2023
Merged

Fix Dialog/DialogOutlet/Transition behavior #12

merged 14 commits into from
Sep 5, 2023

Conversation

DavidVollmers
Copy link
Owner

  • Rename IgnisOutletComponentBase to IgnisContentProviderComponentBase and rework its behavior
  • Rename OutletBase to ContentHostBase and rework its behavior
  • Remove IOutlet, IOutletComponent, IOutletRegistry and IOutletRegistrySubscriber interfaces
  • Introduce IContentHost, IContentProvider, IContentRegistry and IContentRegistrySubscriber interfaces
  • Update Dialog component to work with the new classes and interfaces
  • Update Transition to work with the new classes and interfaces if the transition contains a Dialog child component

@DavidVollmers DavidVollmers merged commit 22cff01 into master Sep 5, 2023
2 checks passed
@DavidVollmers DavidVollmers deleted the bugfix/fix-outlet branch September 5, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@DavidVollmers