Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Move programmatically set yScaleMin, yScaleMax and yScaleOffset to skin.conf #61

Closed
Daveiano opened this issue Aug 27, 2022 · 0 comments · Fixed by #62
Closed

[BUG] Move programmatically set yScaleMin, yScaleMax and yScaleOffset to skin.conf #61

Daveiano opened this issue Aug 27, 2022 · 0 comments · Fixed by #62
Labels
bug Something isn't working enhancement New feature or request

Comments

@Daveiano
Copy link
Owner

Describe the bug
Follow up of #49. There are still some programmatically set default values for yScaleMin, yScaleMax and yScaleOffset. Some of these default values lead to unpredictable results for the end-user not being aware of the specific set values. For example, humidity has a programmatically set yScaleMin = 0 and yScaleMax = 103, which makes it impossible for the user to set a custom yScaleOffset, because it is ignored when a yScaleMin or yScaleMax is set.

Additional context
https://groups.google.com/g/weewx-user/c/L0IlIQmpa-8/m/TGKseZddBAAJ
@Daveiano Daveiano added bug Something isn't working enhancement New feature or request labels Aug 27, 2022
Daveiano added a commit that referenced this issue Aug 28, 2022
@Daveiano
Fixes [GH-61]
18e1674
@Daveiano Daveiano linked a pull request Aug 28, 2022 that will close this issue
Fixes [GH-61] #62
Merged
Daveiano added a commit that referenced this issue Aug 28, 2022
@Daveiano
Updated changelog. [GH-61]
05f71c5
Daveiano added a commit that referenced this issue Aug 28, 2022
@Daveiano
Merge pull request #62 from Daveiano/61-bug-move-programmatically-set…
b2f84fd 
…-yscalemin-yscalemax-and-yscaleoffset-to-skinconf

Fixes [GH-61]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes [GH-61] Daveiano/weewx-wdc
1 participant
@Daveiano