Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Max Rain Rate Does Not Reset #224

Closed
gary-hammer opened this issue Nov 10, 2023 · 28 comments
Closed

Max Rain Rate Does Not Reset #224

gary-hammer opened this issue Nov 10, 2023 · 28 comments
Labels
bug Something isn't working MQTT
Milestone

Comments

@gary-hammer
Copy link

The max rain rate does not reset. The min may not but as it normally zero hard to tell.
That wasn't noticeable until now.
I have verified that all other min/max seem to be resetting.

Originally posted by @gary-hammer in #198 (comment)

@Daveiano Daveiano added the bug Something isn't working label Nov 10, 2023
@Daveiano
Copy link
Owner

Just had a quick look into the code and it should reset the rainRate. There is a chance of rain for the coming days, so I will have a deeper look soon.

Just to verify: You are talking about this max value in the Rain tile, right?

GH-224-1

@gary-hammer
Copy link
Author

Indeed, the highlighted value does not reset.

@gary-hammer
Copy link
Author

I changed the data feed to the MQTT from my weewx instance that uses a console logger.
It has a complete set of data and is updated every 2.5 seconds.

I'm attaching its output if you need to see it for some reason.
Davis Logger MQTT Output.txt

@Daveiano
Copy link
Owner

Ok, I think I found the bug. Attached is an updated live-updates.js file, please feel free to test this one out (it should alert "rainRate" on first load).

Take your time! I got the luck to have rain for the last 3 days to test this out in real-world conditions.

live-updates.zip

@Daveiano Daveiano added this to the 3.5.0 milestone Nov 15, 2023
Daveiano added a commit that referenced this issue Nov 15, 2023
@gary-hammer
Copy link
Author

Thanks, we're not expecting rain until the weekend.

I do notice an odd behavior.
The apptemp and dewpoint change between two values every loop.
These are different pairs of values. Like 30.5 and 29.4 for apptemp. I have not seen this before.
Perhaps dew point should only change with the archive?
Anyway, I shall report back once it rains.

@gary-hammer
Copy link
Author

To make the two value issue more clear, I have a short video of this.
Notice the apptemp alternates between what looks like the real apptemp and in this case 34 F
The dew point does the same but it isn't as clear.

https://ghammer.net/tab.mp4

Let me know after you view it so I can remove the file.

@Daveiano
Copy link
Owner

I downloaded the video, thank you.

I will have a look at it as soon as possible, reporting back!

@Daveiano
Copy link
Owner

To make the two value issue more clear, I have a short video of this.
Notice the apptemp alternates between what looks like the real apptemp and in this case 34 F
The dew point does the same but it isn't as clear.

I see what is happening, but I can not reproduce it. Realy can't make any sense out of it.

Do you probably have a second MQTT-enabled skin installed to prove if it's the skin's fault or another problem?

@gary-hammer
Copy link
Author

I shall install belchertown in the morning.

It is installed on the live machine and uses the same MQTT feed as this.

But to remove any difference, I'll install on the same machine.

@gary-hammer
Copy link
Author

My main server has a rather odd configuration.
Weather is served from /home/weather/bt
I have installed WDC there and I'm having a time with getting the html_root and base_path set correctly.
This is among the entries I've tried. Where oh where have I went wrong?
[[WdcReport]]
HTML_ROOT = /home/weather/bt/wdc
base_path = /wdc/

@Daveiano
Copy link
Owner

The base_path only depends on your web server configuration and how you are accessing the skin.

So if you are accessing the webpage:

See https://github.com/Daveiano/weewx-wdc/wiki/WeeWX-related#setting-html_root-and-basepath

@gary-hammer
Copy link
Author

https://weather.ghammer.net/wdc/
There is nothing I have tried that works. I just get the framework with no content.
Perhaps this needs to be in Extras?

[[WdcReport]]
HTML_ROOT = /home/weather/bt/wdc
base_path = /wdc

@Daveiano
Copy link
Owner

Sorry, it needs the ending slash:

base_path = /wdc/

@gary-hammer
Copy link
Author

gary-hammer commented Nov 17, 2023

Bingo!
https://weather.ghammer.net/wdc/

No issue on my production server. This is the release version. I'll add the 'rain' version in the morning.

@gary-hammer
Copy link
Author

Well, I think I will wipe and reinstall the test server. I'll let it go through the rain that is forecast to be certain the rate is reset first.

Taking lots of errors now. This is with the 'rain' file installed there. It is not on the production server and all is well there, no errors.
I'm attaching the errors here for you, just in case.
wdc_errors.txt

@Daveiano
Copy link
Owner

No issue on my production server. This is the release version. I'll add the 'rain' version in the morning.

Taking lots of errors now. This is with the 'rain' file installed there. It is not on the production server and all is well there, no errors.

So this sounds like the "alternating two value issue" is solved, right?

I'm attaching the errors here for you, just in case.

I have never seen such errors while developing. This is with weewx 4.10.2, right?

@gary-hammer
Copy link
Author

On the test server/instance, the alternating values continue. It encompasses apptemp, heat index, wind chill, and dew point.
That machine is the only one with the test 'rain_rate' file installed. It is also the one with the errors. It runs weewx v5

I installed, with your help, on my production machine. It runs weewx 4.10.2. No errors in the logs and no alternating values.

I plan to keep the test instance until rain comes to test the fix for the reset. Afterwards, I'm going to install Debian and weewx fresh and install the current release of WDC skin.

@Daveiano
Copy link
Owner

On the test server/instance, the alternating values continue. It encompasses apptemp, heat index, wind chill, and dew point.
That machine is the only one with the test 'rain_rate' file installed. It is also the one with the errors. It runs weewx v5

Ok so the updated "rain file" should not produce these errors, it's not involved when the files are generated by Cheetah, so I assume this is WeeWX v5 related. I did not test the skin with v5 yet. How is the current progress, are we near a stable v5 release, yet?

I installed, with your help, on my production machine. It runs weewx 4.10.2. No errors in the logs and no alternating values.
I plan to keep the test instance until rain comes to test the fix for the reset. Afterwards, I'm going to install Debian and weewx fresh and install the current release of WDC skin.

Sounds great!

@gary-hammer
Copy link
Author

V5 is stable, there are packaging issues as I understand.
This could be a python issue, there have been reports on the WeeWX group of various issues with an updated python.
Not worth the time to troubleshoot as different drivers and skins have been in and out of the test machine and a clean install is in order. Since it is proxmox, I'll just save the image and be able to restore in about a minute going forward.

Rain forecast for my overnight, so Sunday morning I'll know if the reset functions.

@gary-hammer
Copy link
Author

Well, I see that we have had rain since midnight.
The instance on my production server (strictly stock install) shows a max rain rate for the day.
The instance on my test server shows the rain amount but 0 for max rain rate when I open it on a PC. On the tablet where it is always open, it is showing the correct max rain rate for the day.
I'd think it should show the max values no matter when it were opened.

@gary-hammer
Copy link
Author

gary-hammer commented Nov 19, 2023

Max rain rate did reset with the 'rain' skin.

@gary-hammer
Copy link
Author

The alternating values was apparently caused by the MQTTSubscribe driver. I returned to the WLL driver and the issue is gone.

@Daveiano
Copy link
Owner

Max rain rate did reset with the 'rain' skin.

Great, then this change will come to the next release.

The instance on my production server (strictly stock install) shows a max rain rate for the day.
The instance on my test server shows the rain amount but 0 for max rain rate when I open it on a PC. On the tablet where it is always open, it is showing the correct max rain rate for the day.
I'd think it should show the max values no matter when it were opened.

I think I know what's causing this, looks like a bug. I will give you an updated file for testing within this week, if you do not find any other bugs, this version will be in the next release.

Thank you for all the testing!

@gary-hammer
Copy link
Author

Sounds good. Thanks for your rapid fixes!

Daveiano added a commit that referenced this issue Nov 20, 2023
@Daveiano
Copy link
Owner

Here is an updated file (this time without an alert) which should fix the problem described in #224 (comment) AND the rain rate issue.

So please feel free to test this out extensively and report back any problems!

live-updates.zip

@gary-hammer
Copy link
Author

Thanks. File is loaded on both systems.
Just in time, we'll have rain and snow over the next two days.

I'll report back afterwards.

@gary-hammer
Copy link
Author

Rain yesterday, all was well.
This morning, max rain rate is cleared.

As it is our Thanksgiving holiday, I won't be around until Monday.

I'm happy with the results, so feel free to close this ticket.

@Daveiano
Copy link
Owner

Great! Please feel free to open a new issue/discussion if you find another bug.

I wish you a happy Thanksgiving!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working MQTT
Projects
None yet
Development

No branches or pull requests

2 participants