Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tech debt] ICON_DEFAULT looks hard code #404

Closed
vitan opened this issue Sep 12, 2016 · 3 comments
Closed

[tech debt] ICON_DEFAULT looks hard code #404

vitan opened this issue Sep 12, 2016 · 3 comments
Labels
enhancement

Comments

@vitan
Copy link
Contributor

vitan commented Sep 12, 2016

vim src/plugins/catalog/model.go +24 goto the ICON_DEFAULT, we'd better make the value configurable or generate the image auto.
@cmingxu
Copy link
Contributor

cmingxu commented Sep 12, 2016

plain text with base64 encode png would be great.

@vitan
Copy link
Contributor Author

vitan commented Sep 13, 2016

the backend shouldn't serve the static content, let's move the image to frontend and return an none byte to frontend.

@cmingxu
Copy link
Contributor

cmingxu commented Sep 13, 2016

@vitan the reason why store a icon in DB is that we should make api works without frontend provided.

@vitan vitan mentioned this issue Sep 14, 2016
Merged
@vitan vitan closed this as completed Sep 14, 2016
vitan added a commit that referenced this issue Sep 28, 2016
@vitan
Bump v1.0.5
8479c93 
1. I18N
2. Merged blackmamba and rolex into crane
3. Improved the add node function
4. Added id attribute for html
5. Many UE improvements
6. Increased the test coverage
7. Implemented stack templates CRUD
8. Module plugin code refactor
9. Listed the supported OS
10. fixed bugs: #404 , #410, #429, #433, #451, #452, #460, #464, #465,
\#471 , #484, #500, #503, #504, #508, #510, #538
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cmingxu @vitan