Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use proper version string for package.ensure on Windows #741

Merged
merged 2 commits into from
Jun 8, 2022
Merged

Use proper version string for package.ensure on Windows #741

merged 2 commits into from
Jun 8, 2022

Conversation

bkabrda
Copy link
Contributor

@bkabrda bkabrda commented Jun 8, 2022

What does this PR do?

Fixes #730 by adding .1 to the package.ensure attribute on Windows when using a pinned agent version.

Motivation

Additional Notes

Describe your test plan

@bkabrda bkabrda requested a review from a team as a code owner June 8, 2022 11:41
@bkabrda bkabrda merged commit 252da28 into main Jun 8, 2022
@bkabrda bkabrda deleted the slavek.kabrda/windows-package-fix-ensure branch June 8, 2022 13:37
@evojay87 evojay87 mentioned this pull request Aug 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mx-psi mx-psi mx-psi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Windows agent version isn't managed properly
2 participants
@bkabrda @mx-psi