[pkg/otlp/attributes] Handle literal 'host' tag #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mx-psi
commented
May 4, 2023
Comment on lines
-51
to
+64
| // 1. a custom Datadog hostname provided by the "datadog.host.name" attribute | ||
| // 1. the "host" attribute to avoid double tagging if present. | ||
| // | ||
| // 2. cloud provider specific hostname for AWS, Azure or GCP, | ||
| // 2. a custom Datadog hostname provided by the "datadog.host.name" attribute | ||
| // | ||
| // 3. the Kubernetes node name (and cluster name if available), | ||
| // 3. cloud provider specific hostname for AWS, Azure or GCP, | ||
| // | ||
| // 4. the cloud provider host ID and | ||
| // 4. the Kubernetes node name (and cluster name if available), | ||
| // | ||
| // 5. the host.name attribute. | ||
| // 5. the cloud provider host ID and | ||
| // | ||
| // 6. the host.name attribute. |
There was a problem hiding this comment.
This is just adding the top line and bumping the numbers on the rest of items, but the resulting diff is not very readable
songy23
approved these changes
May 4, 2023
| @@ -29,6 +29,9 @@ const ( | |||
| AttributeDatadogHostname = "datadog.host.name" | |||
| // AttributeK8sNodeName the datadog k8s node name attribute | |||
| AttributeK8sNodeName = "k8s.node.name" | |||
| // Attribute host is a literal host tag. | |||
| // We check for this to avoid double tagging. | |||
| AttributeHost = "host" | |||
There was a problem hiding this comment.
IMO it is very confusing that we treat host, host.name and datadog.host.name in subtly different order. This has led to several customer issues.
(Not suggesting to fix it in this PR, but something that needs better documentation)
There was a problem hiding this comment.
That's fair, I think some subtlety is required here but maybe we can do better. For this PR, I am convinced that host needs to go first, since otherwise you get double tagging in some cases, so I will merge, but we should discuss how to improve the situation for the rest.
codeboten
pushed a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
May 5, 2023
…o v0.2.0 (#21507) Bump DataDog/opentelemetry-mapping-go to v0.2.0, to include DataDog/opentelemetry-mapping-go#65 in the next release.
gbbr
reviewed
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Handle literal 'host' attribute when determining the
hosttag value.Motivation
Not doing so causes two
hosttags/attributes to be present on all signal types under certain conditions.