Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pkg/inframetadata] Add support for metrics for host metadata #184

Merged
merged 8 commits into from
Dec 18, 2023
Merged

[pkg/inframetadata] Add support for metrics for host metadata #184

merged 8 commits into from
Dec 18, 2023

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Oct 30, 2023 •
edited
Loading

What does this PR do?

Adds support for CPU and RAM metrics in host metadata:

  • We take the latest point from the metric when updating metadata.
  • As opposed to changes on resource attributes, we do not track updates to the host metadata payload and do not force sending a new host metadata payload, since for metrics like frequency this would lead to too frequent updates

Motivation

These are commonly used fields in host metadata

@mx-psi mx-psi force-pushed the mx-psi/metrics-support branch 2 times, most recently from 8de0ac1 to 1cab46a Compare December 15, 2023 11:07
@mx-psi mx-psi added the breaking-change This PR introduces a Go API breaking change label Dec 15, 2023
@mx-psi mx-psi marked this pull request as ready for review December 15, 2023 12:10
@mx-psi mx-psi requested a review from a team as a code owner December 15, 2023 12:10
songy23
songy23 reviewed Dec 15, 2023
View reviewed changes
pkg/inframetadata/internal/hostmap/hostmap.go Outdated Show resolved Hide resolved
pkg/inframetadata/reporter.go Show resolved Hide resolved
pkg/inframetadata/reporter.go Outdated Show resolved Hide resolved
@mx-psi mx-psi removed the breaking-change This PR introduces a Go API breaking change label Dec 15, 2023
@mx-psi mx-psi requested a review from songy23 December 18, 2023 17:07
songy23
songy23 approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mx-psi mx-psi merged commit 082c3c8 into main Dec 18, 2023
7 checks passed
@mx-psi mx-psi deleted the mx-psi/metrics-support branch December 18, 2023 18:53
@mx-psi mx-psi mentioned this pull request Dec 21, 2023
Merged
codeboten pushed a commit to open-telemetry/opentelemetry-collector-contrib that referenced this pull request Dec 21, 2023
@mx-psi
[*/datadog] Update to opentelemetry-mapping-go v0.11.0 (#30158)
9a34aea 
**Description:** 

- [*/datadog] Bump to opentelemetry-mapping-go v0.11.0. This includes:
  - Refactor related to upcoming metric:
    - DataDog/opentelemetry-mapping-go/pull/230
    - DataDog/opentelemetry-mapping-go/pull/231
    - DataDog/opentelemetry-mapping-go/pull/229
  - Host metadata updates:
    - DataDog/opentelemetry-mapping-go/pull/184
    - DataDog/opentelemetry-mapping-go/pull/225
- Use `logs.Translator` for logs implementation
- Set `MeterProvider` to noop to prevent sending metrics for now until
we agree on the design. Note that I reverted one of the changelog items
added in #29785, since it's no longer true that we add this metric.
nslaughter pushed a commit to nslaughter/opentelemetry-collector-contrib that referenced this pull request Dec 27, 2023
@mx-psi @nslaughter
[*/datadog] Update to opentelemetry-mapping-go v0.11.0 (open-telemetr…
2d63784 
…y#30158)

**Description:** 

- [*/datadog] Bump to opentelemetry-mapping-go v0.11.0. This includes:
  - Refactor related to upcoming metric:
    - DataDog/opentelemetry-mapping-go/pull/230
    - DataDog/opentelemetry-mapping-go/pull/231
    - DataDog/opentelemetry-mapping-go/pull/229
  - Host metadata updates:
    - DataDog/opentelemetry-mapping-go/pull/184
    - DataDog/opentelemetry-mapping-go/pull/225
- Use `logs.Translator` for logs implementation
- Set `MeterProvider` to noop to prevent sending metrics for now until
we agree on the design. Note that I reverted one of the changelog items
added in open-telemetry#29785, since it's no longer true that we add this metric.
nslaughter pushed a commit to nslaughter/opentelemetry-collector-contrib that referenced this pull request Dec 27, 2023
@mx-psi @nslaughter
[*/datadog] Update to opentelemetry-mapping-go v0.11.0 (open-telemetr…
5d02e6c 
…y#30158)

**Description:** 

- [*/datadog] Bump to opentelemetry-mapping-go v0.11.0. This includes:
  - Refactor related to upcoming metric:
    - DataDog/opentelemetry-mapping-go/pull/230
    - DataDog/opentelemetry-mapping-go/pull/231
    - DataDog/opentelemetry-mapping-go/pull/229
  - Host metadata updates:
    - DataDog/opentelemetry-mapping-go/pull/184
    - DataDog/opentelemetry-mapping-go/pull/225
- Use `logs.Translator` for logs implementation
- Set `MeterProvider` to noop to prevent sending metrics for now until
we agree on the design. Note that I reverted one of the changelog items
added in open-telemetry#29785, since it's no longer true that we add this metric.
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this pull request Jan 10, 2024
@mx-psi @cparkins
[*/datadog] Update to opentelemetry-mapping-go v0.11.0 (open-telemetr…
3045ff4 
…y#30158)

**Description:** 

- [*/datadog] Bump to opentelemetry-mapping-go v0.11.0. This includes:
  - Refactor related to upcoming metric:
    - DataDog/opentelemetry-mapping-go/pull/230
    - DataDog/opentelemetry-mapping-go/pull/231
    - DataDog/opentelemetry-mapping-go/pull/229
  - Host metadata updates:
    - DataDog/opentelemetry-mapping-go/pull/184
    - DataDog/opentelemetry-mapping-go/pull/225
- Use `logs.Translator` for logs implementation
- Set `MeterProvider` to noop to prevent sending metrics for now until
we agree on the design. Note that I reverted one of the changelog items
added in open-telemetry#29785, since it's no longer true that we add this metric.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@songy23 songy23 songy23 approved these changes

@liustanley liustanley Awaiting requested review from liustanley liustanley is a code owner automatically assigned from DataDog/opentelemetry

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mx-psi @songy23