Use Spotless for formatting #1619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces the gradle googleJavaFormat plugin, but still using that format within spotless.
I applied settings in attempt to get as close as I could, but change set is still pretty dramatic and the result is unappealing. (Idea formatting does a better job.)
jpbempel
approved these changes
Jun 23, 2020
|
If we're changing this can we change the format too? Sometimes the current format splits single statements across 4 or more lines. |
|
@richardstartin I expect changes to the format can be done as a PR that changes the config and applies it to everything. I was trying to keep the changes minimal to start. Most of the changes here are files that weren't automatically formatted on the previous system. |
devinsba
approved these changes
Jun 23, 2020
tylerbenson
added
the
tag: no release notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the gradle googleJavaFormat plugin, but still using that format within spotless.
Includes a precommit hook to help verify.