Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddtrace/tracer: fix infinite recursion in (*safeSource).Seed call #560

Merged
merged 3 commits into from
Feb 14, 2020
Merged

ddtrace/tracer: fix infinite recursion in (*safeSource).Seed call #560

merged 3 commits into from
Feb 14, 2020

Conversation

mbranch
Copy link
Contributor

@mbranch mbranch commented Jan 7, 2020 •
edited
Loading

This probably has never occurred since Seed doesn't appear to be called anywhere, but it's a bug nonetheless.

I'll also mention that it's worth using linters[1][2], which nicely assist catching these subtle bugs.

  1. golangci-lint: https://github.com/golangci/golangci-lint
  2. https://staticcheck.io/docs/checks#SA5007

@gbbr gbbr changed the title Fix infinite recursive call ddtrace/tracer: fix infinite recursion in (*safeSource).Seed call Jan 8, 2020
@gbbr gbbr added this to the 1.21.0 milestone Jan 8, 2020
gbbr
gbbr approved these changes Jan 8, 2020
View reviewed changes
Copy link
Contributor

@gbbr gbbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! We will merge it soon.

@knusbaum knusbaum modified the milestones: 1.21.0, 1.22.0 Feb 4, 2020
knusbaum
knusbaum approved these changes Feb 14, 2020
View reviewed changes
Copy link
Contributor

@knusbaum knusbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@knusbaum knusbaum merged commit f885fb3 into DataDog:v1 Feb 14, 2020
@gbbr gbbr added this to the 1.22.0 milestone Feb 17, 2020
mingrammer pushed a commit to mingrammer/dd-trace-go that referenced this pull request Dec 22, 2020
@mbranch @mingrammer
Fix infinite recursive call (DataDog#560)
793b5c8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knusbaum knusbaum knusbaum approved these changes

@gbbr gbbr gbbr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mbranch @knusbaum @gbbr