contrib/gomodule/redigo: Support ConnWithTimeout interface (#535) #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbbr
reviewed
Dec 20, 2019
gbbr
previously approved these changes
Dec 20, 2019
|
Thanks for the quick review! CI passes now, but because I force pushed I erased your approval... |
gbbr
reviewed
Dec 20, 2019
gbbr
reviewed
Dec 20, 2019
Although all Conn implementations shipped in redigo also implement ConnWithTimeout, we handle both cases in the code to deal with custom Dial functions that would return implementations that implement Conn only. Fixes #535
gbbr
approved these changes
Dec 20, 2019
|
Great, thanks for the super efficient review :) |
knusbaum
approved these changes
Jan 27, 2020
|
Thank you, @abustany |
mingrammer
pushed a commit
to mingrammer/dd-trace-go
that referenced
this pull request
Dec 22, 2020
Although all Conn implementations shipped in redigo also implement ConnWithTimeout, we handle both cases in the code to deal with custom Dial functions that would return implementations that implement Conn only. Fixes DataDog#535
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although all Conn implementations shipped in redigo also implement
ConnWithTimeout, we handle both cases in the code to deal with custom
Dial functions that would return implementations that implement Conn
only.
Fixes #535