Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore]ddtrace/tracer: added a WithAgentTimeout option to reduce the test suite duration with no agent #2661

Merged
merged 9 commits into from
Apr 22, 2024
Merged

[chore]ddtrace/tracer: added a WithAgentTimeout option to reduce the test suite duration with no agent #2661

merged 9 commits into from
Apr 22, 2024

Conversation

dianashevchenko
Copy link
Contributor

What does this PR do?

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@pr-commenter
Copy link

pr-commenter bot commented Apr 17, 2024 •
edited
Loading

Benchmarks

Benchmark execution time: 2024-04-19 13:01:24

Comparing candidate commit e61260a in PR branch shevchenko/fix-long-test-duration with baseline commit fda4cc5 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 43 metrics, 1 unstable metrics.

darccio
darccio requested changes Apr 17, 2024
View reviewed changes
ddtrace/internal/globaltracer.go Outdated Show resolved Hide resolved
ddtrace/tracer/meta_struct_test.go Show resolved Hide resolved
ddtrace/tracer/metrics_test.go Show resolved Hide resolved
ddtrace/tracer/option.go Outdated Show resolved Hide resolved
ddtrace/tracer/option_test.go Outdated Show resolved Hide resolved
internal/datastreams/transport.go Show resolved Hide resolved
@dianashevchenko dianashevchenko marked this pull request as ready for review April 17, 2024 13:12
@dianashevchenko dianashevchenko requested review from a team as code owners April 17, 2024 13:12
darccio
darccio approved these changes Apr 18, 2024
View reviewed changes
Copy link
Member

@darccio darccio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving again.

@dianashevchenko dianashevchenko enabled auto-merge (squash) April 19, 2024 12:39
@dianashevchenko dianashevchenko changed the title [chore]ddtrace/tracer: reducing the test suite duration with no agent [chore]ddtrace/tracer: added a WithAgentTimeout option to reduce the test suite duration with no agent Apr 22, 2024
@dianashevchenko dianashevchenko merged commit eee2487 into main Apr 22, 2024
158 checks passed
@dianashevchenko dianashevchenko deleted the shevchenko/fix-long-test-duration branch April 22, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darccio darccio darccio approved these changes

@piochelepiotr piochelepiotr piochelepiotr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dianashevchenko @darccio @piochelepiotr