Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appsec: collect edge waf headers #2637

Merged
merged 3 commits into from
Apr 2, 2024

Conversation

Julio-Guerra
Copy link
Contributor

@Julio-Guerra Julio-Guerra commented Mar 29, 2024

What does this PR do?

Collect more HTTP headers from different WAF vendors in the request span.

System tests: DataDog/system-tests#2287

Motivation

ASM's integration with thrid-party edge WAFs (CloudFlare WAF, AWS WAF...)

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

For Datadog employees:

  • If this PR touches code that handles credentials of any kind, such as Datadog API keys, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@Julio-Guerra Julio-Guerra requested a review from a team as a code owner March 29, 2024 14:40
Copy link
Contributor

@eliottness eliottness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust you to double check on the new list of headers since I don't have a link to the document referencing them.

internal/appsec/trace/httptrace/http.go Show resolved Hide resolved
@pr-commenter
Copy link

pr-commenter bot commented Apr 2, 2024

Benchmarks

Benchmark execution time: 2024-04-02 13:21:01

Comparing candidate commit 7416d85 in PR branch julio.guerra/appsec-edge-waf-headers with baseline commit 23b2b69 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 43 metrics, 1 unstable metrics.

@Julio-Guerra Julio-Guerra enabled auto-merge (squash) April 2, 2024 12:59
@Julio-Guerra Julio-Guerra merged commit 192fb73 into main Apr 2, 2024
199 checks passed
@Julio-Guerra Julio-Guerra deleted the julio.guerra/appsec-edge-waf-headers branch April 2, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants