Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/samplernames: fixes a colliding sampler name #2627

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

yuanyuanzhao3
Copy link
Collaborator

sampler name 9 was reserved for OTel ingestion but not documented.
The new sampler for remote user rule also uses 9. This fixes the collide.

What does this PR do?

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

For Datadog employees:

  • If this PR touches code that handles credentials of any kind, such as Datadog API keys, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

…undocumented one.

sampler name `9` was reserved for OTel ingestion but not documented. This fixes the collide.
@yuanyuanzhao3 yuanyuanzhao3 requested a review from a team as a code owner March 21, 2024 16:22
@darccio
Copy link
Member

darccio commented Mar 21, 2024

As discussed with @yuanyuanzhao3, the current values are not yet in use. Approved.

@darccio darccio merged commit 0120fd1 into main Mar 21, 2024
156 of 157 checks passed
@darccio darccio deleted the yuanyuan.zhao/fix-sampler-names branch March 21, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants