Change binary to use io.Reader #2329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
os.File is very inconvenient when you work with in memory data. This is a small backward incompatible change but I think it's alright.
therve
added
the
changelog/Changed
skarimo
approved these changes
Dec 22, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Dec 22, 2023
* Change binary to use io.Reader os.File is very inconvenient when you work with in memory data. This is a small backward incompatible change but I think it's alright. * Cassettes :# 2a5860b
mx-psi
pushed a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Jan 16, 2024
…30577) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/DataDog/datadog-api-client-go/v2](https://togithub.com/DataDog/datadog-api-client-go) | `v2.20.0` -> `v2.21.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>DataDog/datadog-api-client-go (github.com/DataDog/datadog-api-client-go/v2)</summary> ### [`v2.21.0`](https://togithub.com/DataDog/datadog-api-client-go/releases/tag/v2.21.0) [Compare Source](https://togithub.com/DataDog/datadog-api-client-go/compare/v2.20.0...v2.21.0) <!-- Release notes generated using configuration in .github/release.yml at v2.21.0 --> #### What's Changed ##### Added - Add priority field to SDS rule and standard-pattern by [@​api-clients-generation-pipeline](https://togithub.com/api-clients-generation-pipeline) in [DataDog/datadog-api-client-go#2317 - Document new `resource_collection` and `is_security_command_center_enabled` fields in GCP APIs by [@​api-clients-generation-pipeline](https://togithub.com/api-clients-generation-pipeline) in [DataDog/datadog-api-client-go#2318 - Add SAML attributes by [@​api-clients-generation-pipeline](https://togithub.com/api-clients-generation-pipeline) in [DataDog/datadog-api-client-go#2311 - Security Monitoring - Support custom third party rules by [@​api-clients-generation-pipeline](https://togithub.com/api-clients-generation-pipeline) in [DataDog/datadog-api-client-go#2337 - Add public API support for time-slice SLOs by [@​api-clients-generation-pipeline](https://togithub.com/api-clients-generation-pipeline) in [DataDog/datadog-api-client-go#2328 - Add included_keyword_configuration field to SDS rule by [@​api-clients-generation-pipeline](https://togithub.com/api-clients-generation-pipeline) in [DataDog/datadog-api-client-go#2340 - Update Documentation for APM DevSecOps by [@​api-clients-generation-pipeline](https://togithub.com/api-clients-generation-pipeline) in [DataDog/datadog-api-client-go#2341 ##### Changed - Change binary to use io.Reader by [@​therve](https://togithub.com/therve) in [DataDog/datadog-api-client-go#2329 - Mark v1 downtime endpoints as deprecated by [@​api-clients-generation-pipeline](https://togithub.com/api-clients-generation-pipeline) in [DataDog/datadog-api-client-go#2334 - Adding Cloud Cost Management API Documentation by [@​api-clients-generation-pipeline](https://togithub.com/api-clients-generation-pipeline) in [DataDog/datadog-api-client-go#2326 - Add support for Cloudflare API `zone` and `resource` fields by [@​api-clients-generation-pipeline](https://togithub.com/api-clients-generation-pipeline) in [DataDog/datadog-api-client-go#2339 **Full Changelog**: DataDog/datadog-api-client-go@v2.20.0...v2.21.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjcuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEyNy4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <[email protected]>
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Feb 1, 2024
…pen-telemetry#30577) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/DataDog/datadog-api-client-go/v2](https://togithub.com/DataDog/datadog-api-client-go) | `v2.20.0` -> `v2.21.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>DataDog/datadog-api-client-go (github.com/DataDog/datadog-api-client-go/v2)</summary> ### [`v2.21.0`](https://togithub.com/DataDog/datadog-api-client-go/releases/tag/v2.21.0) [Compare Source](https://togithub.com/DataDog/datadog-api-client-go/compare/v2.20.0...v2.21.0) <!-- Release notes generated using configuration in .github/release.yml at v2.21.0 --> #### What's Changed ##### Added - Add priority field to SDS rule and standard-pattern by [@&open-telemetry#8203;api-clients-generation-pipeline](https://togithub.com/api-clients-generation-pipeline) in [DataDog/datadog-api-client-go#2317 - Document new `resource_collection` and `is_security_command_center_enabled` fields in GCP APIs by [@&open-telemetry#8203;api-clients-generation-pipeline](https://togithub.com/api-clients-generation-pipeline) in [DataDog/datadog-api-client-go#2318 - Add SAML attributes by [@&open-telemetry#8203;api-clients-generation-pipeline](https://togithub.com/api-clients-generation-pipeline) in [DataDog/datadog-api-client-go#2311 - Security Monitoring - Support custom third party rules by [@&open-telemetry#8203;api-clients-generation-pipeline](https://togithub.com/api-clients-generation-pipeline) in [DataDog/datadog-api-client-go#2337 - Add public API support for time-slice SLOs by [@&open-telemetry#8203;api-clients-generation-pipeline](https://togithub.com/api-clients-generation-pipeline) in [DataDog/datadog-api-client-go#2328 - Add included_keyword_configuration field to SDS rule by [@&open-telemetry#8203;api-clients-generation-pipeline](https://togithub.com/api-clients-generation-pipeline) in [DataDog/datadog-api-client-go#2340 - Update Documentation for APM DevSecOps by [@&open-telemetry#8203;api-clients-generation-pipeline](https://togithub.com/api-clients-generation-pipeline) in [DataDog/datadog-api-client-go#2341 ##### Changed - Change binary to use io.Reader by [@&open-telemetry#8203;therve](https://togithub.com/therve) in [DataDog/datadog-api-client-go#2329 - Mark v1 downtime endpoints as deprecated by [@&open-telemetry#8203;api-clients-generation-pipeline](https://togithub.com/api-clients-generation-pipeline) in [DataDog/datadog-api-client-go#2334 - Adding Cloud Cost Management API Documentation by [@&open-telemetry#8203;api-clients-generation-pipeline](https://togithub.com/api-clients-generation-pipeline) in [DataDog/datadog-api-client-go#2326 - Add support for Cloudflare API `zone` and `resource` fields by [@&open-telemetry#8203;api-clients-generation-pipeline](https://togithub.com/api-clients-generation-pipeline) in [DataDog/datadog-api-client-go#2339 **Full Changelog**: DataDog/datadog-api-client-go@v2.20.0...v2.21.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjcuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEyNy4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <[email protected]>
anthoai97
pushed a commit
to anthoai97/opentelemetry-collector-contrib
that referenced
this pull request
Feb 12, 2024
](https://renovatebot.com){kind=link}
…pen-telemetry#30577) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/DataDog/datadog-api-client-go/v2](https://togithub.com/DataDog/datadog-api-client-go) | `v2.20.0` -> `v2.21.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>DataDog/datadog-api-client-go (github.com/DataDog/datadog-api-client-go/v2)</summary> ### [`v2.21.0`](https://togithub.com/DataDog/datadog-api-client-go/releases/tag/v2.21.0) [Compare Source](https://togithub.com/DataDog/datadog-api-client-go/compare/v2.20.0...v2.21.0) <!-- Release notes generated using configuration in .github/release.yml at v2.21.0 --> #### What's Changed ##### Added - Add priority field to SDS rule and standard-pattern by [@&open-telemetry#8203;api-clients-generation-pipeline](https://togithub.com/api-clients-generation-pipeline) in [DataDog/datadog-api-client-go#2317 - Document new `resource_collection` and `is_security_command_center_enabled` fields in GCP APIs by [@&open-telemetry#8203;api-clients-generation-pipeline](https://togithub.com/api-clients-generation-pipeline) in [DataDog/datadog-api-client-go#2318 - Add SAML attributes by [@&open-telemetry#8203;api-clients-generation-pipeline](https://togithub.com/api-clients-generation-pipeline) in [DataDog/datadog-api-client-go#2311 - Security Monitoring - Support custom third party rules by [@&open-telemetry#8203;api-clients-generation-pipeline](https://togithub.com/api-clients-generation-pipeline) in [DataDog/datadog-api-client-go#2337 - Add public API support for time-slice SLOs by [@&open-telemetry#8203;api-clients-generation-pipeline](https://togithub.com/api-clients-generation-pipeline) in [DataDog/datadog-api-client-go#2328 - Add included_keyword_configuration field to SDS rule by [@&open-telemetry#8203;api-clients-generation-pipeline](https://togithub.com/api-clients-generation-pipeline) in [DataDog/datadog-api-client-go#2340 - Update Documentation for APM DevSecOps by [@&open-telemetry#8203;api-clients-generation-pipeline](https://togithub.com/api-clients-generation-pipeline) in [DataDog/datadog-api-client-go#2341 ##### Changed - Change binary to use io.Reader by [@&open-telemetry#8203;therve](https://togithub.com/therve) in [DataDog/datadog-api-client-go#2329 - Mark v1 downtime endpoints as deprecated by [@&open-telemetry#8203;api-clients-generation-pipeline](https://togithub.com/api-clients-generation-pipeline) in [DataDog/datadog-api-client-go#2334 - Adding Cloud Cost Management API Documentation by [@&open-telemetry#8203;api-clients-generation-pipeline](https://togithub.com/api-clients-generation-pipeline) in [DataDog/datadog-api-client-go#2326 - Add support for Cloudflare API `zone` and `resource` fields by [@&open-telemetry#8203;api-clients-generation-pipeline](https://togithub.com/api-clients-generation-pipeline) in [DataDog/datadog-api-client-go#2339 **Full Changelog**: DataDog/datadog-api-client-go@v2.20.0...v2.21.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjcuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEyNy4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
os.File is very inconvenient when you work with in memory data. This is a small backward incompatible change but I think it's alright.