Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: set proper default value for aggregator_buffer_size and dogstatsd_string_interner_size #4893

Merged
merged 1 commit into from
Feb 14, 2020

Conversation

remeh
Copy link
Contributor

@remeh remeh commented Feb 13, 2020

The default value for these two new fields were not handled properly.

(For history, these fields were added in #4749 and #4879)

@remeh remeh added [deprecated] team/agent-core Deprecated. Use metrics-logs / shared-components labels instead.. changelog/no-changelog labels Feb 13, 2020
@remeh remeh added this to the 7.18.0 milestone Feb 13, 2020
@remeh remeh requested a review from a team as a code owner February 13, 2020 16:31
Copy link
Member

@olivielpeau olivielpeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@remeh remeh merged commit d454524 into master Feb 14, 2020
@remeh remeh deleted the remeh/default-config branch February 14, 2020 08:24
xornivore added a commit that referenced this pull request Mar 6, 2020
… and `dogstatsd_string_interner_size` (#4893)"

This reverts commit d454524.
xornivore added a commit that referenced this pull request Mar 9, 2020
… and `dogstatsd_string_interner_size` (#4893)"

This reverts commit d454524.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog [deprecated] team/agent-core Deprecated. Use metrics-logs / shared-components labels instead..
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants