Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix template embedding on windows #4862

Merged
merged 1 commit into from
Feb 11, 2020
Merged

Fix template embedding on windows #4862

merged 1 commit into from
Feb 11, 2020

Conversation

prognant
Copy link
Contributor

What does this PR do?

#4782 broke the agent status command on windows because of the \ vs / convention.

Motivation

Fix a regression introduce by PR #4782

Additional Notes

N/A

@prognant prognant requested a review from a team as a code owner February 10, 2020 14:53
@prognant prognant added changelog/no-changelog [deprecated] team/agent-core Deprecated. Use metrics-logs / shared-components labels instead.. labels Feb 10, 2020
@prognant prognant added this to the 7.18.0 milestone Feb 10, 2020
olivielpeau
olivielpeau approved these changes Feb 10, 2020
View reviewed changes
Copy link
Member

@olivielpeau olivielpeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM 👍

A couple of questions:

  • were you able to test this on both Linux and Windows? (would make sense to test on the resulting packages to be sure, once they're built by gitlab)
  • is there a way we could test some of this logic in unit tests? (open question, I can't think of a way, so kitchen tests might be the only place where we can test any of this)

@prognant prognant merged commit 2866f57 into master Feb 11, 2020
@prognant
Copy link
Contributor Author

prognant commented Feb 11, 2020 •
edited
Loading

I tested the change on Windows 10 / Linux / Macosx, I will also test the package.
I tried to find out a way to write a unit test that would have caught the issue, and I did not find a reasonable way to do it in unit tests.

@remeh remeh deleted the prognant/fix-template-embedding-on-windows branch February 21, 2020 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivielpeau olivielpeau olivielpeau approved these changes

Assignees
No one assigned
Labels
changelog/no-changelog [deprecated] team/agent-core Deprecated. Use metrics-logs / shared-components labels instead..
Projects
None yet
Milestone
7.18.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@prognant @olivielpeau