change mkHuman() to exclude unit conversion and format large numbers … #4850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darthnater007
added
[deprecated] team/agent-core
|
|
remeh
previously approved these changes
Feb 7, 2020
remeh
reviewed
Feb 7, 2020
…b.com:DataDog/datadog-agent into precision_status
remeh
approved these changes
Feb 10, 2020
There was a problem hiding this comment.
LGTM!
We could reconsider the needs of the mkHuman method in helpers.go now that it only calls humanize, but in the end, it abstracts it and its nice to have it in our helpers anyway (it makes sense to have this kind of helper directly in the datadog-agent without having to think about which lib to import, etc.).
Thank you!
darthnater007
deleted the
nate_perkins/precision_values_on_agent_status
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Agent statuses currently display imprecise numbers for large numbers (>1,000,000 shows a 1 M). This excludes thsi unit conversion in favor of more precise numbers from agent statuses
Motivation
Card: https://trello.com/c/5GcxDW96/1489-status-cmd-keep-precision-for-all-internal-stats-shown-by-status-command
Additional Notes
There is a test for the mkHuman() function as well.
My local test runs showed that this change forwards to the agent status command and the GUI (screenshots below):
Feed dummy value to MkHuman to test:
https://share.getcloudapp.com/2NurGqXY
GUI:
https://share.getcloudapp.com/jkun9PqJ
Command Line Status:
https://share.getcloudapp.com/4gux6nP5