-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
telemetry: adds the telemetry package and related features. #4599
Conversation
1aa0b6c
to
7ccc798
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First pass, looks clean and simple 👍
6a977bf
to
cbe0b2a
Compare
Should we change |
@albertvaka Absolutely! I've sent a commit. |
I'll approve once someone from agent-core approves. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a nit, should be ready to merge after it 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📦
) * telemetry: adds the telemetry package and related features. * telemetry: add observability metrics using the telemetry feature. * telemetry: linter compliant. * telemetry: metrics samples is a counter. * telemetry: use constants for Ok / Error states. * telemetry: optional subsystem + address missing metrics.
42a0922
What does this PR do?
Adds a
telemetry
package in order to add observability metrics on the internal behavior of the Agent.Motivation
Having a better observability on the internal of the Agents to constantly ensure the quality and the good behavior of the Agent while working on new releases.
Additional Notes
The observability metrics are added in #4600