Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

telemetry: adds the telemetry package and related features. #4599

Merged
merged 14 commits into from
Jan 9, 2020

Conversation

remeh
Copy link
Contributor

@remeh remeh commented Dec 13, 2019

What does this PR do?

Adds a telemetry package in order to add observability metrics on the internal behavior of the Agent.

Motivation

Having a better observability on the internal of the Agents to constantly ensure the quality and the good behavior of the Agent while working on new releases.

Additional Notes

The observability metrics are added in #4600

@remeh remeh added [deprecated] team/agent-core Deprecated. Use metrics-logs / shared-components labels instead.. changelog/no-changelog labels Dec 13, 2019
@remeh remeh added this to the 7.17.0 milestone Dec 13, 2019
@remeh remeh requested review from a team as code owners December 13, 2019 10:12
Copy link
Member

@arbll arbll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass, looks clean and simple 👍

pkg/collector/corechecks/embed/apm.go Show resolved Hide resolved
pkg/collector/corechecks/embed/jmx/check.go Show resolved Hide resolved
pkg/telemetry/prom_counter.go Outdated Show resolved Hide resolved
pkg/telemetry/gauge.go Outdated Show resolved Hide resolved
@albertvaka
Copy link
Contributor

Should we change CODEOWNERS so telemetry is owned by agent core?

@remeh
Copy link
Contributor Author

remeh commented Jan 2, 2020

@albertvaka Absolutely! I've sent a commit.

@albertvaka
Copy link
Contributor

I'll approve once someone from agent-core approves.

cmd/agent/app/run.go Outdated Show resolved Hide resolved
@remeh remeh requested a review from a team as a code owner January 6, 2020 15:04
arbll
arbll previously approved these changes Jan 7, 2020
Copy link
Member

@arbll arbll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit, should be ready to merge after it 👍

pkg/telemetry/gauge.go Outdated Show resolved Hide resolved
arbll
arbll previously approved these changes Jan 7, 2020
Copy link
Member

@arbll arbll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📦

clamoriniere
clamoriniere previously approved these changes Jan 7, 2020
albertvaka
albertvaka previously approved these changes Jan 7, 2020
shang-wang
shang-wang previously approved these changes Jan 8, 2020
)

* telemetry: adds the telemetry package and related features.
* telemetry: add observability metrics using the telemetry feature.
* telemetry: linter compliant.
* telemetry: metrics samples is a counter.
* telemetry: use constants for Ok / Error states.
* telemetry: optional subsystem + address missing metrics.
@remeh remeh requested a review from a team as a code owner January 9, 2020 14:54
@remeh remeh merged commit 09957f7 into master Jan 9, 2020
@dd-devflow dd-devflow bot deleted the remeh/telemetry-feature branch April 19, 2024 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog [deprecated] team/agent-core Deprecated. Use metrics-logs / shared-components labels instead..
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants