pkg/trace/{obfuscate,agent}: remove obfuscator dependency on config package #4209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ackage This change removes the 'obfuscate' package's dependency on the 'config' package in an attempt to reduce transitive dependency and make it more accessible to outside users. * Before: 176 transitive dependencies * After: 106 transitive dependencies (87 standard library, 19 for models)
gbbr
force-pushed
the
gbbr/obfuscate-light
branch
from
2e21d4d
to
4e48454
Compare
erichgess
approved these changes
Sep 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes the 'obfuscate' package's dependency on the 'config'
package in an attempt to reduce transitive dependency and make it more
accessible to outside users.
To view, use
go list -f '{{ join .Deps "\n" }}' ./pkg/trace/obfuscate