Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/trace/info: separate payload_too_large from decoding_error #4007

Merged
merged 1 commit into from
Aug 14, 2019

Conversation

gbbr
Copy link
Contributor

@gbbr gbbr commented Aug 13, 2019

This change adds a new reason for dropped payloads: payload_too_large.
Previously, this reason was mashed together with decoding_error which
presented the risk of misleading viewers to believe that an invalid
payload was sent, when in fact a valid one might've been sent, but the
10M API limit was overflown.

This change adds a new reason for dropped payloads: `payload_too_large`.
Previously, this reason was mashed together with `decoding_error` which
presented the risk of misleading viewers to believe that an invalid
payload was sent, when in fact a valid one might've been sent, but the
10M API limit was overflown.
@gbbr gbbr added the team/agent-apm trace-agent label Aug 13, 2019
@gbbr gbbr added this to the 6.14.0 milestone Aug 13, 2019
@gbbr gbbr requested a review from djova August 13, 2019 12:05
@gbbr gbbr merged commit a80daac into master Aug 14, 2019
@gbbr gbbr deleted the gbbr/reason-too-large branch August 14, 2019 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team/agent-apm trace-agent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants