pkg/trace/agent: add language tags to processed traces #3858
+105
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change introduces language tags to processed traces. Previously, metrics like `*.traces_priority` had no language tags.
djova
approved these changes
Jul 11, 2019
|
|
||
| // We get the address of the struct holding the stats associated to no tags. | ||
| // TODO: get the real tagStats related to this trace payload (per lang/version). |
There was a problem hiding this comment.
A TODO actually getting done. That is rare 😛
There was a problem hiding this comment.
That TODO is older than me 😆
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces language tags to processed traces. Previously,
metrics like
*.traces_priorityhad no language tags.