Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/trace/agent: remove concentrator routine #3838

Merged
merged 1 commit into from
Jul 9, 2019
Merged

pkg/trace/agent: remove concentrator routine #3838

merged 1 commit into from
Jul 9, 2019

Conversation

gbbr
Copy link
Contributor

@gbbr gbbr commented Jul 9, 2019

This PR removes the concentrator goroutine, which served no purpose. It instead adds "number of cores" goroutines as workers to process stats.

58k spans/s

Screen Shot 2019-07-09 at 9 56 24 AM

@gbbr gbbr added this to the 6.13.0 milestone Jul 9, 2019
@gbbr gbbr force-pushed the gbbr/no-concentrator branch 2 times, most recently from f1ef861 to c9b4b30 Compare July 9, 2019 14:04
@gbbr gbbr merged commit 0090707 into master Jul 9, 2019
@gbbr gbbr deleted the gbbr/no-concentrator branch July 9, 2019 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LotharSee LotharSee LotharSee approved these changes

Assignees
No one assigned
Labels
changelog/no-changelog team/agent-apm trace-agent
Projects
None yet
Milestone
6.13.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gbbr @LotharSee