-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
macos: do not include SDS in the build #25236
Conversation
Regression DetectorRegression Detector ResultsRun ID: 06bcc77d-b447-4f29-988c-3b8964cf8a5d Performance changes are noted in the perf column of each table:
Significant changes in experiment optimization goalsConfidence level: 90.00%
|
perf | experiment | goal | Δ mean % | Δ mean % CI |
---|---|---|---|---|
❌ | file_to_blackhole | % cpu utilization | +154.19 | [+144.72, +163.66] |
Fine details of change detection per experiment
perf | experiment | goal | Δ mean % | Δ mean % CI |
---|---|---|---|---|
✅ | tcp_syslog_to_blackhole | ingress throughput | +5601.81 | [+5365.21, +5838.41] |
❌ | file_to_blackhole | % cpu utilization | +154.19 | [+144.72, +163.66] |
➖ | process_agent_real_time_mode | memory utilization | +4.55 | [+4.27, +4.84] |
➖ | pycheck_1000_100byte_tags | % cpu utilization | +1.46 | [-3.32, +6.25] |
➖ | file_tree | memory utilization | +0.63 | [+0.50, +0.76] |
➖ | process_agent_standard_check | memory utilization | +0.62 | [+0.56, +0.67] |
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +0.57 | [-2.31, +3.45] |
➖ | idle | memory utilization | +0.54 | [+0.50, +0.59] |
➖ | trace_agent_json | ingress throughput | +0.01 | [-0.01, +0.02] |
➖ | uds_dogstatsd_to_api | ingress throughput | +0.01 | [-0.20, +0.21] |
➖ | trace_agent_msgpack | ingress throughput | -0.02 | [-0.03, -0.00] |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.02 | [-0.06, +0.03] |
➖ | otel_to_otel_logs | ingress throughput | -0.02 | [-0.38, +0.33] |
➖ | basic_py_check | % cpu utilization | -0.14 | [-2.61, +2.33] |
➖ | process_agent_standard_check_with_stats | memory utilization | -0.30 | [-0.36, -0.25] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
[Fast Unit Tests Report] On pipeline 33225789 (CI Visibility). The following jobs did not run any unit tests: Jobs:
If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-developer-experience |
/merge |
🚂 MergeQueue Pull request added to the queue. This build is next! (estimated merge in less than 51m) Use |
* macos: do not include SDS in the build * Instead of "not supporting" macOS, only supports Linux.
APR-94
What does this PR do?
Unsupported platform for now, we don't want to include SDS in the macOS build.
Motivation
DMG builds are broken in
main
, this PR is the easy fix, meanwhile, I'm working on a separate PR trying to fix the build instead.