Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tasks+omnibus: use a versioned SDS shared library. #24668

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

remeh
Copy link
Contributor

@remeh remeh commented Apr 15, 2024

APR-94

What does this PR do?

Use a pinned version of the SDS shared library.

@remeh remeh added changelog/no-changelog qa/no-code-change Skip QA week as there is no code change in Agent code team/agent-processing-and-routing labels Apr 15, 2024
@remeh remeh requested review from a team as code owners April 15, 2024 07:39
Copy link
Member

@FlorentClarret FlorentClarret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thank you 🎉 ! I just left one question

omnibus/config/software/sds.rb Outdated Show resolved Hide resolved
# no Windows support for now.
if linux_target? || osx_target?
command "git checkout #{sds_version}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% sure but think this isn't required. Omnibus should interpret the default version as a git ref and checkout automatically

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm giving it a shot!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be working. Any chance you would know how to double-check this from the jobs worker or similar?

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Apr 15, 2024

[Fast Unit Tests Report]

On pipeline 32088510 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-developer-experience

@pr-commenter
Copy link

pr-commenter bot commented Apr 15, 2024

Regression Detector

Regression Detector Results

Run ID: d0b2e149-88a1-4a05-bc7c-579f35ff89d9
Baseline: 2be60ca
Comparison: 6f6596e

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +0.74 [-4.73, +6.21]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
pycheck_1000_100byte_tags % cpu utilization +1.65 [-3.34, +6.63]
basic_py_check % cpu utilization +1.41 [-1.04, +3.86]
file_to_blackhole % cpu utilization +0.74 [-4.73, +6.21]
idle memory utilization +0.13 [+0.09, +0.17]
otel_to_otel_logs ingress throughput +0.11 [-0.33, +0.55]
process_agent_real_time_mode memory utilization +0.02 [-0.03, +0.07]
tcp_dd_logs_filter_exclude ingress throughput +0.02 [-0.02, +0.07]
trace_agent_json ingress throughput +0.02 [-0.01, +0.04]
tcp_syslog_to_blackhole ingress throughput +0.01 [-0.07, +0.10]
uds_dogstatsd_to_api ingress throughput +0.00 [-0.20, +0.20]
trace_agent_msgpack ingress throughput +0.00 [-0.00, +0.00]
process_agent_standard_check memory utilization -0.02 [-0.07, +0.04]
process_agent_standard_check_with_stats memory utilization -0.06 [-0.11, -0.01]
file_tree memory utilization -0.45 [-0.57, -0.34]
uds_dogstatsd_to_api_cpu % cpu utilization -0.96 [-3.94, +2.01]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Copy link
Contributor

@chouquette chouquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@remeh
Copy link
Contributor Author

remeh commented Apr 15, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Apr 15, 2024

🚂 MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

@dd-devflow
Copy link

dd-devflow bot commented Apr 15, 2024

🚂 MergeQueue

Pull request added to the queue.

This build is going to start soon! (estimated merge in less than 24m)

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit cb16bd3 into main Apr 15, 2024
188 checks passed
@dd-mergequeue dd-mergequeue bot deleted the remeh/versioned-sds branch April 15, 2024 14:35
@github-actions github-actions bot added this to the 7.54.0 milestone Apr 15, 2024
CelianR pushed a commit that referenced this pull request Apr 26, 2024
* tasks+omnibus: use a versioned SDS shared library.

* tasks+omnibus: rely on default_version for omnibus + python linting
alexgallotta pushed a commit that referenced this pull request May 9, 2024
* tasks+omnibus: use a versioned SDS shared library.

* tasks+omnibus: rely on default_version for omnibus + python linting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/no-code-change Skip QA week as there is no code change in Agent code team/agent-processing-and-routing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants