Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logs: rules as received from RC use some specific consts. #24484

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

remeh
Copy link
Contributor

@remeh remeh commented Apr 8, 2024

APR-94

What does this PR do?

  • Moves interpreting rules received through RC in a separate function for clarity
  • Uses specific consts strings when interpreting rules received through RC, as these consts don't fully matches strings used in the library itself (which was a naive assumption).

Describe how to test/QA your changes

Not necessary, it will be tested during the #23915 QA (that's actually going through this that I've detected it).

@remeh
Copy link
Contributor Author

remeh commented Apr 8, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Apr 8, 2024

🚂 MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

@pr-commenter
Copy link

pr-commenter bot commented Apr 8, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=31635424 --os-family=ubuntu

@dd-devflow
Copy link

dd-devflow bot commented Apr 8, 2024

🚂 MergeQueue

Pull request added to the queue.

This build is going to start soon! (estimated merge in less than 23m)

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit 415f595 into main Apr 8, 2024
193 of 194 checks passed
@dd-mergequeue dd-mergequeue bot deleted the remeh/sds-rc-rules branch April 8, 2024 16:30
@github-actions github-actions bot added this to the 7.54.0 milestone Apr 8, 2024
@remeh remeh added the qa/done Skip QA week as QA was done before merge and regressions are covered by tests label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/done Skip QA week as QA was done before merge and regressions are covered by tests team/agent-processing-and-routing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants