[no-aggregation] return the MetricSampleBatch to the pool only once done with it
#17728
Conversation
… done with it. Returning the `MetricSampleBatch` earlier (in the `batcher.go`) was incorrect since the `NoAggregationStreamWorker` goroutine might still be using it to process its content. Returning it early was making the MetricSampleBatch available to any running `TimeSamplerWorker`s, which has the time to write (by indices) its sample in the MetricSampleBatch, eventually still processed (with access by index) by the `NoAggregationStreaWorker`, resulting in misuse of the metric sample (or its discard if it is a no-aggregation unsupported type such as Distribution and Histograms).
Bloop Bleep... Dogbot HereRegression Detector ResultsRun ID: 573dd2da-cdf2-436a-87da-b9b714968e62 ExplanationA regression test is an integrated performance test for Because a target's optimization goal performance in each experiment will vary somewhat each time it is run, we can only estimate mean differences in optimization goal relative to the baseline target. We express these differences as a percentage change relative to the baseline target, denoted "Δ mean %". These estimates are made to a precision that balances accuracy and cost control. We represent this precision as a 90.00% confidence interval denoted "Δ mean % CI": there is a 90.00% chance that the true value of "Δ mean %" is in that interval. We decide whether a change in performance is a "regression" -- a change worth investigating further -- if both of the following two criteria are true:
The table below, if present, lists those experiments that have experienced a statistically significant change in mean optimization goal performance between baseline and comparison SHAs with 90.00% confidence OR have been detected as newly erratic. Negative values of "Δ mean %" mean that baseline is faster, whereas positive values of "Δ mean %" mean that comparison is faster. Results that do not exhibit more than a ±5.00% change in their mean optimization goal are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting change is observed. No interesting changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%. Fine details of change detection per experiment.
|
… done with it (#17728) * [no-aggregation] return the `MetricSampleBatch` to the pool only once done with it. Returning the `MetricSampleBatch` earlier (in the `batcher.go`) was incorrect since the `NoAggregationStreamWorker` goroutine might still be using it to process its content. Returning it early was making the MetricSampleBatch available to any running `TimeSamplerWorker`s, which has the time to write (by indices) its sample in the MetricSampleBatch, eventually still processed (with access by index) by the `NoAggregationStreaWorker`, resulting in misuse of the metric sample (or its discard if it is a no-aggregation unsupported type such as Distribution and Histograms).
Returning the
MetricSampleBatchearlier (in thebatcher.go) was incorrect since theNoAggregationStreamWorkergoroutine might still be using it to process its content.Returning it early was making the MetricSampleBatch available to any running
TimeSamplerWorkers, which has the time to write (by indices) its sample in the MetricSampleBatch, eventually still processed (with access by index) by theNoAggregationStreamWorker, resulting in misuse of the metric sample (or its discard if it is a no-aggregation unsupported type such as Distribution and Histograms).Describe how to test/QA your changes
statsd_normal.gofrom this gist in a loop:while [ "1" = "1" ]; do go run statsd_normal.go; donestatsd_noagg.gofrom this gist in a loop:while [ "1" = "1" ]; do go run statsd_noagg.go; doneWait for a couple minutes and validate that no warning log message (
Discarding unsupported metric sample...) are present.log_payloads: truedo echo -n 'foo:1|c|#tags|T1687203807' | socat -t 0 - UNIX-CLIENT:/path/to/your/statsd.sock) and make sure it is sent properly.Reviewer's Checklist
Triagemilestone is set.major_changelabel if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.changelog/no-changeloglabel has been applied.qa/skip-qalabel is not applied.team/..label has been applied, indicating the team(s) that should QA this change.need-change/operatorandneed-change/helmlabels have been applied.k8s/<min-version>label, indicating the lowest Kubernetes version compatible with this feature.