[demultiplexer] change the API to something clearer about DSD samples and timed samples #13247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and timed samples. * `AddTimeSample` is only used to add DogStatsD sample, it makes better sense named `AddDSDSample` * `AddTimeSampleBatch` is only used to add DogStatsD sample, it makes better sense named `AddDSDSamples` * `AddLateMetrics` is only about sending timed samples to the no-agg pipeline, it makes better sense named `AddTimedSample`
`AddDSDSample` -> `AggregateSample` `AddDSDSamples` -> `AggregateSamples` `AddTimedSample` -> `SendSamplesWithoutAggregation` `AddCheckSample` -> `AggregateCheckSample`
vickenty
approved these changes
Aug 29, 2022
purple4reina
approved these changes
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Renamed some methods in the
Demultiplexerinterface:AddTimeSampleis only used to aggregate DogStatsD sample, it makes better sense namedAggregateSampleAddTimeSampleBatchis only used to aggregate DogStatsD samples, it makes better sense namedAggregateSamplesAddLateMetricsis only about sending timed samples to the no-agg pipeline, it makes better sense namedSendSamplesWithoutAggregationAddCheckSampleis about aggregating check sample, better namedAggregateCheckSampleMotivation
Clearer API in the
Demultiplexers implementations.Describe how to test/QA your changes
If DogStatsD traffic is still working, we're fine, it's just a renaming PR.
Reviewer's Checklist
Triagemilestone is set.major_changelabel if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.changelog/no-changeloglabel has been applied.qa/skip-qalabel is not applied.team/..label has been applied, indicating the team(s) that should QA this change.need-change/operatorandneed-change/helmlabels have been applied.k8s/<min-version>label, indicating the lowest Kubernetes version compatible with this feature.