Feature tankview refactor #1529
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Sherman 105 sight corrected to fire onto crosshair -Commander view zoomed in to allow easier usage The 105 sherman didnt fire to its crosshair before, and the cupola view of the 105 was god awfull, zoomed in to give some substance too it.
Stug had multiple cupola views for some odd reason, cupola view now dead center (in between the lower and upper view from before) ||#detheelinization||
All tanks listed now fire to their respective crosshairs, mainly American and British tanks who have static magnified scopes, tanks with dynamic range adjustments did not need the calibration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Sherman 105 and jumbo cupola views zoomed in to enable proper usage
-stug3 cupola view(s) reduced to one centered view
-American and British tank gun-sights calibrated
Sherman 105 and Jumbo's cupola view was gaudy, looked terrible and had poor visibility, increased the zoom in the view to allow better usage of the position.
Stug3 had weird "lower" and "higher" views when in the cupola, both removed and a centered cupola view found.
American Tanks as well as some British (American made like the Sherman) had weird sight calibrations that did not fire to their cross-hair, they now fire to their respective cross-hairs.