This repository has been archived by the owner on Apr 25, 2020. It is now read-only.
GHC-8.6.1/Nightly-2018-10-17 #943
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Again, I threw stuff at the compiler until it... well, compiled. Specs pass, apparently.
Mostly some changes to internal types.
One major change is that
<-patterns that may fail now require the monad in question to haveMonadFailinstance. I figured this out rather late into the process, so it so happens I have replaced fallible patterns withfromJustNotewhere appropriate, I think in one place using an irrefutable pattern, and withheadin another. There is little rhyme or reason to why I used a particular way to do this. I just chose whatever seemed the most convenient at the time.Note: this branch is only compatible with ghc 8.6, I threw away some CPP guards and didn't bother with introducing new ones in the slightest. I vaguely remember that splitting off ghc-mod-core was in part in order to ditch all that CPP horribleness by tying the core to GHC releases. I guess that never happened? Anyway, be careful with this.