This repository has been archived by the owner on Apr 25, 2020. It is now read-only.
Some improvement on ghc-show-type #480
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It can be customized by "ghc-type-region" face.
Region selected by ghc-show-type can be copied or killed by "C-w" or "M-w" respectively. The type string can be copied by "M-t".
| @@ -31,10 +31,25 @@ | |||
| ;;; type | |||
| ;;; | |||
|
|
|||
| (defface ghc-type-region | |||
There was a problem hiding this comment.
This face makes text under it quite unreadable, at least with my theme. How about we use an underline face or something less intrusive instead? Or maybe base the default colors for this theme on ones from the default faces of the current theme and modify them a bit.
|
I think your comments are reasonable, but I cannot do the change by myself anytime soon. Feel free to close this PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit introduces new face instead of
regionface sinceregionface confuses user that it is normal region (while it is not actually).The second commit reduces this confusion to make
C-wandM-wwork as in normal region.Also
M-tcopies the type string to kill ring.