Skip to content
This repository has been archived by the owner on Apr 25, 2020. It is now read-only.

enable syntax check on save in literate haskell mode #389

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

enable syntax check on save in literate haskell mode #389

wants to merge 1 commit into from

Conversation

kiripon
Copy link
Contributor

@kiripon kiripon commented Oct 7, 2014

No description provided.

@kiripon
Copy link
Contributor Author

kiripon commented Oct 12, 2014

In my environment, when emacs is in literate-haskell-mode, syntax checks doesn't work on saving a file.
I think this small fix will activate ghc-chck-syntax in literate-haskell-mode.
Could you pull it?

@kiripon kiripon closed this Nov 4, 2014
@DanielG
Copy link
Owner

DanielG commented Nov 4, 2014

Any reason you closed this request? I was just holding off merging it until I come around to looking at the elisp stuff again, which I had to postpone because university is keeping me busy.

@DanielG DanielG reopened this Nov 4, 2014
@DanielG
Copy link
Owner

DanielG commented Aug 20, 2015

@kazu-yamamoto do we still need this PR?

@kazu-yamamoto
Copy link
Collaborator

I think we can accept this pull request if @kiripon wishes.

@DanielG
Copy link
Owner

DanielG commented Aug 20, 2015

Well I'm more asking does it look like it's going to break something ;)

@kazu-yamamoto
Copy link
Collaborator

I don't think that this breaks something.

@iquiw
Copy link
Contributor

iquiw commented Aug 20, 2015

Just curious.
Is there any reason to use defadvice instead of after-save-hook?

@kazu-yamamoto
Copy link
Collaborator

No. I did not hit upon after-save-hook when I implemented it.

BTW, now #550 is implemented. So, we don't have to save the buffer at all anymore.
Should we provide a new key-binding to check syntax?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants